[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

2020-05-22 Thread GitBox
comaniac commented on issue #5647: URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632907849 Thanks @mbrookhart for the quick fix :) This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

2020-05-21 Thread GitBox
comaniac commented on issue #5647: URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632406321 Ah I see. Yeah then I totally agree that using pre-order traversal would be cleaner. This is an automated

[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

2020-05-21 Thread GitBox
comaniac commented on issue #5647: URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632403232 I encountered the similar issue before when we were implementing `PartitionGraph` pass in BYOC. We then had a group merging mechanism as you mentioned. I think I