[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-17 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-660067570 Hi @anijain2305 , @tmoreau89 , @kparzysz-quic I addressed the name change, reformatted the help text in `math.py` and addressed an integration change in the arm

[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-15 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-658711649 Quick update on this. * I had to remove checks for input data type to be `int32` from the intrinsic (and TOPI). Indeed, this can be called from

[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-658328391 @anijain2305 , @tmoreau89 , @kparzysz-quic I tried to address/reply to your comments. I added a `test_fixed_point_multiply()` in `test_op_level3.py` to test the

[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-13 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-657448386 @anijain2305 @kparzysz-quic @tqchen Any update on this? This is an automated message from the Apache Git

[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-08 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-655639521 Following the discussion in the [RFC](https://discuss.tvm.ai/t/rfc-using-arm-intrinsics-to-implement-fixed-point-multiplication-in-tvm) I redesigned the submission by

[GitHub] [incubator-tvm] giuseros commented on pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-02 Thread GitBox
giuseros commented on pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#issuecomment-65255 cc @tqchen @anijain2305 @kparzysz-quic This is an automated message from the Apache Git Service. To