gussmith23 commented on issue #4348: [Relay] Add tests in CI which run tests
based on specific Relay feature flags
URL: https://github.com/apache/incubator-tvm/issues/4348#issuecomment-557685873
- Yeah, it seems like Steven's idea would work here. Just glob them from the
`transform` module.
- In #3236, Marisa writes "we can also bake this into the pass manager: each
pass will have to specify three more argument: FeatureSet input_features,
FeatureSet add_features, FeatureSet remove_features, that denote which feature
can this pass handle, which feature it may add, and which feature it will
remove." From my understanding of the pass manager code, it seems like
`PassInfo` might be the most logical place to add these things.
- Are you asking whether we'll need to save the state of the passes, to
check whether they abide by the add_features/remove_features they've specified?
If so, we might start with the easiest solution, which would be to _not_ save
the before/after state of the pass, and _not_ check whether it abides by its
claimed add_features/remove_features. Instead, we could just use this meta-data
in the CI tests that we create. These CI tests will inspect a pass, get its
input_features/add_features/remove_features, and select test programs with the
appropriate features. It'll run the passes over those test programs and ensure
that add_features/remove_features is not violated. Thus, the running of the
passes themselves, over normal code, in the normal compilation process, won't
be affected, and this added metadata will only be used by our new test suite.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
