[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-08 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r422452792 ## File path: python/tvm/relay/op/_transform.py ## @@ -189,10 +192,9 @@ def _reshape_shape_func(data_shape, newshape, ndim):

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-04 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r419566833 ## File path: src/relay/transforms/pattern_util.h ## @@ -270,7 +270,7 @@ inline Constant MakeConstantScalar(DataType dtype, T value) { */

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-04 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r419566554 ## File path: tests/python/relay/test_any.py ## @@ -138,23 +138,35 @@ def test_any_concat(): result = ex.evaluate()(x_np, y_np)

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-01 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r418654995 ## File path: src/relay/transforms/fuse_ops.cc ## @@ -234,6 +235,8 @@ class IndexedForwardGraph::Creator : private ExprVisitor { Node* node

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-01 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r418644990 ## File path: src/relay/transforms/pattern_util.h ## @@ -270,7 +270,7 @@ inline Constant MakeConstantScalar(DataType dtype, T value) { */

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-05-01 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r418644047 ## File path: src/relay/op/tensor/transform.cc ## @@ -504,17 +548,38 @@ bool ReshapeRel(const Array& types, return false; } - const

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

2020-04-25 Thread GitBox
icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r415137698 ## File path: include/tvm/relay/op_attr_types.h ## @@ -81,10 +81,16 @@ using TOpIsStateful = bool; */ using TNonComputational = bool; +enum