subject:"\[GitHub\] \[incubator\-tvm\] jcf94 edited a comment on pull request #5924\: \[Arith\]\[GPU\]Rewrite simplify fix for Vectorized Cooperative Fetching"

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox

jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail. For example in

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox

jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail, for exp `test_arith_intset.py`.

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox

jcf94 edited a comment on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail.