jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-654736887
Okay I addressed the vast majority of comments directly and hopefully got
everything, CI is building if people can do another pass.
-
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-654525930
@ANSHUMAN87 here is some initial details
https://discuss.tvm.ai/t/rfc-meta-rfc-3-pronged-plan-for-improving-error-messages-in-tvm/7214
-
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-654518640
@ANSHUMAN87 I have been super busy and will post one soon.
This is an automated message from the Apache Gi
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651433312
cc @antinucleon and @jwfromm
This is an automated message from the Apache Git Service.
To respond to the
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651432640
I just marked this as ready for review, my suggestion is that we review the
existing code and land it in an experimental state. I will finish the metadata
parsing and inte
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651432041
cc @MarisaKirisame @joshpoll @wweic @zhiics
This is an automated message from the Apache Git Service.
To
jroesch commented on pull request #5932:
URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651316682
@weberlo I think ANTLR only provides those benefits if you assume the people
working on the project actually know ANTLR, which in so far as I can tell is
not true. Josh an
