junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631931496
The CI error is not relevant to this PR
This is an automated message from the Apache Git Service.
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631147088
Given the fact that `dmlc::LogMessageFatal` causes significant amount of
increase in stack size, we investigated into dmlc-core. The initial results
shows that we
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631032099
Will add container tests after the CI is green
This is an automated message from the Apache Git
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631020339
So the takeaway is that if a method that intends to be inlined by the
compiler, we should take extreme care about the `CHECK`s inside, in case that
the code in
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-630957728
Just to share some interesting updates on the stack utilization issue:
I dig around with gcc `-fstack-usage`.
```
# before this change
virtual
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-629833710
I will add cpptest after the main part is finalized :-)
This is an automated message from the
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-629594362
@tqchen @zhiics Review comments addressed, please take another look :-)
This is an automated
junrushao1994 commented on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-628999732
Could you help review the PR? Thanks! @tqchen @joshpoll @jroesch @zhiics
@icemelon9 @yzhliu @wweic
