[GitHub] [incubator-tvm] masahi commented on issue #5116: Add thrust support for nms

2020-03-23 Thread GitBox
masahi commented on issue #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116#issuecomment-602921562 Thanks @Laurawly @kazum This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-tvm] masahi commented on issue #5116: Add thrust support for nms

2020-03-22 Thread GitBox
masahi commented on issue #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116#issuecomment-602303395 > Lemme know if the changes look good to you Yes this looks great! Thanks This is

[GitHub] [incubator-tvm] masahi commented on issue #5116: Add thrust support for nms

2020-03-21 Thread GitBox
masahi commented on issue #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116#issuecomment-602147401 @Laurawly Can we have implementation like this? Big if/else blocks should be put inside ` thrust_sort_common`. ``` TVM_REGISTER_GLOBAL("tvm.con

[GitHub] [incubator-tvm] masahi commented on issue #5116: Add thrust support for nms

2020-03-20 Thread GitBox
masahi commented on issue #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116#issuecomment-601960643 @Laurawly Can we refactor `thrust_sort` and `thrust_sort_nms`? I see considerable duplicate. ---