[GitHub] [incubator-tvm] masahi commented on pull request #5683: [PYTORCH]Minor bug fixes
masahi commented on pull request #5683: URL: https://github.com/apache/incubator-tvm/pull/5683#issuecomment-635805483 Thanks @siju-samuel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5683: [PYTORCH]Minor bug fixes
masahi commented on pull request #5683: URL: https://github.com/apache/incubator-tvm/pull/5683#issuecomment-635683945 yes this is also a good option if the model is not too complicated. It is up to @siju-samuel. See our lstm tests https://github.com/apache/incubator-tvm/blob/master/tests/python/frontend/pytorch/lstm_test.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5683: [PYTORCH]Minor bug fixes
masahi commented on pull request #5683: URL: https://github.com/apache/incubator-tvm/pull/5683#issuecomment-635648772 You can add BERT tests to the repo and only execute them if import succeeds. They won't be run on CI but we can test them locally. Since BERT seems popular, it would be nice to have an example of how to load them with our PyTorch frontend. @siju-samuel Do you want to do it? Otherwise I can merge this as it is. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5683: [PYTORCH]Minor bug fixes
masahi commented on pull request #5683: URL: https://github.com/apache/incubator-tvm/pull/5683#issuecomment-635017710 Can you add tests? Otherwise it's hard to tell what the problems are. Adding BERT to tests sounds interesting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org