[GitHub] [incubator-tvm] masahi commented on pull request #5689: [PatternLang] Add ConstantPattern

[GitBox]

masahi commented on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635675471


   @comaniac @mbrookhart good to go?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] masahi commented on pull request #5689: [PatternLang] Add ConstantPattern

[GitBox]

masahi commented on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635658618


   > @masahi I just checked with this PR. The unit test hits the line you 
pointed out twice.
   
   hmm something seems off to me. On the dnnl fused mobilenet tests, I think 
all params in the network should go through that visitor. In 
https://github.com/apache/incubator-tvm/pull/5310, @zhiics improved how to 
handle big constants, which made running fused mobilenet possible. If the 
visitor is called only twice, we shouldn't have had such issues at all.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] masahi commented on pull request #5689: [PatternLang] Add ConstantPattern

[GitBox]

masahi commented on pull request #5689:
URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901


   I expect constants to be available to external codegen at compile time. 
Otherwise we cannot do constant folding.
   
   @comaniac Under the current constant impl of partitioning, do you hit this 
visitor 
https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/contrib/dnnl/codegen.cc#L156
 during DNNL codegen? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org