[GitHub] [incubator-tvm] mbaret commented on pull request #5884: [RELAY] Allow non-CSourceModules to compile

2020-06-23 Thread GitBox
mbaret commented on pull request #5884: URL: https://github.com/apache/incubator-tvm/pull/5884#issuecomment-648001235 Superseded by https://github.com/apache/incubator-tvm/pull/5885 This is an automated message from the Apach

[GitHub] [incubator-tvm] mbaret commented on pull request #5884: [RELAY] Allow non-CSourceModules to compile

2020-06-22 Thread GitBox
mbaret commented on pull request #5884: URL: https://github.com/apache/incubator-tvm/pull/5884#issuecomment-647610930 Seeing as that part doesn't look like it has dependencies on the JSON runtime stuff, could you publish it as a standalone PR and I'll abandon this one? --

[GitHub] [incubator-tvm] mbaret commented on pull request #5884: [RELAY] Allow non-CSourceModules to compile

2020-06-22 Thread GitBox
mbaret commented on pull request #5884: URL: https://github.com/apache/incubator-tvm/pull/5884#issuecomment-647606415 I think this is a cleaner alternative for now. Currently we can't rebase on top of your commit because of that CHECK. Our Ethos-N integration uses a completely custom runti

[GitHub] [incubator-tvm] mbaret commented on pull request #5884: [RELAY] Allow non-CSourceModules to compile

2020-06-22 Thread GitBox
mbaret commented on pull request #5884: URL: https://github.com/apache/incubator-tvm/pull/5884#issuecomment-647602667 cc @zhiics @lhutton1 This is an automated message from the Apache Git Service. To respond to the message,