[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-11 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671882417 Thanks @tqchen for the suggestion. I'll work on adding the rfactor support and update the PR once its done. Also, could you explain what you meant by

[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-09 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671139917 Hi @tqchen Thanks for the comments. I was aware of the issue with rfactor primitive, and so I added a check that fails if `init` is used with the rfactor

[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-09 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671139917 Hi @tqchen Thanks for the comments. I was aware of the issue with rfactor primitive, and so I added a check that fails if `init` is used with the rfactor

[GitHub] [incubator-tvm] quic-sanirudh edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-07-26 Thread GitBox
quic-sanirudh edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-664016097 This is my first time contributing to TVM and I have tried to follow all the instructions for Contributors from the documentation, but please let me know I