[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442164092 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442146948 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442033597 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1755,12 +1809,21 @@ def _convert_data_type(input_type): return "int8"

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442088235 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442071688 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):