[GitHub] [incubator-tvm] soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

2020-02-25 Thread GitBox
soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591064120 I definitely agree that we'll want that eventually. However, improved pattern matching won't

[GitHub] [incubator-tvm] soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

2020-02-25 Thread GitBox
soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591014458 Got it, I see what you're saying. I'm still not convinced that we want to generalize sorting

[GitHub] [incubator-tvm] soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

2020-02-25 Thread GitBox
soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591008923 Sorry, I don't quite understand - where do you think the change should be made? The main issue