[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442784734 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442747459 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442747459 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442174045 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442163343 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442162253 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442145084 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442145084 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442105064 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442105064 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442079677 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070736 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070171 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066837 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):