[GitHub] [incubator-tvm] t-vi commented on pull request #5887: keep parameter names from PyTorch

2020-06-23 Thread GitBox
t-vi commented on pull request #5887: URL: https://github.com/apache/incubator-tvm/pull/5887#issuecomment-648023393 #5897 has the fix. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-tvm] t-vi commented on pull request #5887: keep parameter names from PyTorch

2020-06-23 Thread GitBox
t-vi commented on pull request #5887: URL: https://github.com/apache/incubator-tvm/pull/5887#issuecomment-648010250 I found the problem and will send a fix. The old code included the embedding weight twice (which arguably is a bug in itself and needs fixing) and the new code deduplicated

[GitHub] [incubator-tvm] t-vi commented on pull request #5887: keep parameter names from PyTorch

2020-06-23 Thread GitBox
t-vi commented on pull request #5887: URL: https://github.com/apache/incubator-tvm/pull/5887#issuecomment-647989008 What is the error you are seeing? This is an automated message from the Apache Git Service. To respond to