tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-660356504
I'm thinking that the `static auto-tune using profiling results` can also be
separated out in a standalone PR
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-660355629
@zhanghaohit I took a second look at the changes in this PR, and I believe
it would be best to break the PR down into separate, smaller PRs:
(1) modifications to
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-660185671
@zhanghaohit thanks for the follow up. I recommend to echo @liangfu to
rebase so the PR can be in a mergeable state. In addition, if the target is a
custom FPGA board,
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-650347598
In addition were you able to put a guide together? Which Intel FPGA have you
tested this on?
This
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-650347427
@zhanghaohit good news, the end to end tests ran successfully on VTA
hardware with your changes. Given that this PR brings modifications to the ISA
spec, we need to
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-648435167
Thanks @zhanghaohit I can generate the new VTA design on Pynq to verify that
it still passes on the new ISA. I will let you know if this passes.
Installation
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-646918453
Thanks @zhanghaohit for the contribution! I've taken a quick pass but will
need to make a more thorough pass next.
I believe it's important to check two things:
tmoreau89 commented on pull request #5842:
URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-646427274
CC-ing @vegaluisjose @huajsj @pasqoc
This is an automated message from the Apache Git Service.
To
