[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5740: [Object][Runtime] Introduce runtime::Map

2020-06-13 Thread GitBox
tqchen commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r439784420 ## File path: include/tvm/node/container.h ## @@ -43,51 +45,1184 @@ using runtime::Downcast; using runtime::IterAdapter; using runtime::make_object

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5740: [Object][Runtime] Introduce runtime::Map

2020-06-10 Thread GitBox
tqchen commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r438213646 ## File path: include/tvm/runtime/container.h ## @@ -1554,6 +1604,925 @@ struct PackedFuncValueConverter> { } }; +/*! \brief map node content *

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5740: [Object][Runtime] Introduce runtime::Map

2020-06-09 Thread GitBox
tqchen commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r437819343 ## File path: include/tvm/runtime/container.h ## @@ -65,11 +66,36 @@ #include #include +#if defined(_MSC_VER) && !defined(__clang__) +uint32_t

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5740: [Object][Runtime] Introduce runtime::Map

2020-06-09 Thread GitBox
tqchen commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r437819343 ## File path: include/tvm/runtime/container.h ## @@ -65,11 +66,36 @@ #include #include +#if defined(_MSC_VER) && !defined(__clang__) +uint32_t

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5740: [Object][Runtime] Introduce runtime::Map

2020-06-09 Thread GitBox
tqchen commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r437781344 ## File path: src/runtime/builtin_int_lib.cc ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr