[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557294283 @yzhliu can you act on this? I think this is the last blocking item, then we can cut

[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557195441 Interesting, this could due to the fact that we offload floordiv to floor(div(a, b)) and somehow the two was not consistent(perhaps due to

[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-20 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-556334154 I don't think it will make the cut, as the danger was when the result of division was near 0.5, we should check a / b see if it close to

[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-20 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-556142661 it has nothing to do with the min, but with the way we generate the test data