[GitHub] [incubator-tvm] tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables
tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-607938301 Thanks @hzfan for keep improving the code and maintain a high standard. Thanks @yzhliu @Hzfengsy for helpful reviews, this PR is now merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables
tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-606966333 @hzfan Good work. We are in the progress of migrating to the new transform pass manager API. Can you also add a variant of the pass for IRModule and change the testcases to the new style? We can still keep using the old API until we migrated everything itno the new pass style. reference https://github.com/apache/incubator-tvm/pull/5198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables
tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-603902755 @spectrometerHBH @FrozenGene @Hzfengsy please also help to take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
