[GitHub] [incubator-tvm] tqchen commented on issue #5559: [TIR] Bugs in HoistIfThenElse

2020-06-27 Thread GitBox 


tqchen commented on issue #5559:
URL: https://github.com/apache/incubator-tvm/issues/5559#issuecomment-650581654


   https://github.com/apache/incubator-tvm/pull/5944 removes this pass for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5559: [TIR] Bugs in HoistIfThenElse

2020-06-15 Thread GitBox 


tqchen commented on issue #5559:
URL: https://github.com/apache/incubator-tvm/issues/5559#issuecomment-644270821


   Given that this pass is not product ready and we have not yet migrated this 
pass to the transform. Perhaps we can remove the pass for now, and then add it 
back once we have a better impl. Leaving the thread open for a week to see how 
would everyone think



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5559: [TIR] Bugs in HoistIfThenElse

2020-05-28 Thread GitBox 


tqchen commented on issue #5559:
URL: https://github.com/apache/incubator-tvm/issues/5559#issuecomment-635745118


   We could certainly rewrite the pass completely, instad of the PostOrderVisit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5559: [TIR] Bugs in HoistIfThenElse

2020-05-28 Thread GitBox 


tqchen commented on issue #5559:
URL: https://github.com/apache/incubator-tvm/issues/5559#issuecomment-635724547


   @roastduck would you be interested in taking over the pass?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5559: [TIR] Bugs in HoistIfThenElse

2020-05-15 Thread GitBox 


tqchen commented on issue #5559:
URL: https://github.com/apache/incubator-tvm/issues/5559#issuecomment-629506961


   @kevinthesun it would be great if you can followup



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org