[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-24 Thread GitBox
tqchen commented on pull request #5423: URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-619192968 ping @jroesch This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-24 Thread GitBox
tqchen commented on pull request #5423: URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-619153621 The code still works, the overflow children will need to go through the overflow path, and call

[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-23 Thread GitBox
tqchen commented on pull request #5423: URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-618627418 The inhertitance will still work for 3rdparty, because overflow is enabled in all these cases, the support path will be like the same before this PR. we could discuss