[GitHub] [incubator-tvm] tqchen commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-19 Thread GitBox 


tqchen commented on pull request #5740:
URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-646669948


   THanks @junrushao1994 @zhiics !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-18 Thread GitBox 


tqchen commented on pull request #5740:
URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-646353977


   @zhiics please take another look and 
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly
 
   
   cc @wweic @spectrometerHBH @comaniac @antinucleon 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org