[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-27 Thread GitBox
tqchen commented on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650575919 feel free to take your time This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-26 Thread GitBox
tqchen commented on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650457793 ping @giuseros This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-25 Thread GitBox
tqchen commented on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-649753751 Thanks @giuseros can you add a regression test case as per https://tvm.apache.org/docs/contribute/code_review.html#ensure-test-coverage?