[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-671433629 Thanks @quic-sanirudh what you said about rfactor makes sense. We can still support rfactor, by checking the factor indices, and only assign the init value if the fa

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6138: Add `init` member to ReduceNode

2020-08-10 Thread GitBox
tqchen edited a comment on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-670992782 Thanks @quic-sanirudh for proposing the new change. My only conern wrt to the custom initialization value is that it might break the follow up primitives, e.g. rfact