[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-24 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414946295 ## File path: src/te/operation/compute_op.cc ## @@ -231,20 +231,18 @@ void ComputeOpNode::PropBoundToInputs( // undefined

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-24 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414944483 ## File path: include/tvm/arith/analyzer.h ## @@ -411,8 +412,9 @@ class TVM_DLL Analyzer { * * \param var The variable. * \param

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-24 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414940958 ## File path: src/arith/int_set.cc ## @@ -311,6 +311,16 @@ inline IntervalSet Combine(Analyzer* analyzer, LOG(FATAL) << "Modular by

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-24 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414674995 ## File path: src/te/operation/compute_op.cc ## @@ -231,20 +231,18 @@ void ComputeOpNode::PropBoundToInputs( // undefined

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-24 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414674995 ## File path: src/te/operation/compute_op.cc ## @@ -231,20 +231,18 @@ void ComputeOpNode::PropBoundToInputs( // undefined

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414263234 ## File path: src/arith/int_set.cc ## @@ -311,6 +311,21 @@ inline IntervalSet Combine(Analyzer* analyzer, LOG(FATAL) << "Modular by

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414259311 ## File path: include/tvm/arith/int_set.h ## @@ -152,6 +152,22 @@ class IntSet : public ObjectRef {

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414259311 ## File path: include/tvm/arith/int_set.h ## @@ -152,6 +152,22 @@ class IntSet : public ObjectRef {

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r414034656 ## File path: src/arith/const_int_bound.cc ## @@ -150,10 +150,12 @@ class ConstIntBoundAnalyzer::Impl : const PrimExprNode* op =

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413843881 ## File path: src/arith/int_set.cc ## @@ -518,7 +533,14 @@ class IntervalSetEvaluator : // whether set is exactly single point that equals

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-23 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413843721 ## File path: src/arith/int_set.cc ## @@ -372,7 +387,27 @@ class IntervalSetEvaluator : } IntervalSet Eval(const PrimExpr& val) { -

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-22 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413285295 ## File path: src/te/schedule/bound.cc ## @@ -199,11 +202,13 @@ void InferRootBound(const Stage& stage, r = iv->dom; }

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-22 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413277656 ## File path: src/arith/int_set.cc ## @@ -372,7 +387,27 @@ class IntervalSetEvaluator : } IntervalSet Eval(const PrimExpr& val) { -

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-22 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413205094 ## File path: src/arith/int_set.cc ## @@ -518,7 +533,14 @@ class IntervalSetEvaluator : // whether set is exactly single point that equals

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-22 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413188821 ## File path: src/arith/const_int_bound.cc ## @@ -150,10 +150,12 @@ class ConstIntBoundAnalyzer::Impl : const PrimExprNode* op =

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-22 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r413183510 ## File path: src/arith/const_int_bound.cc ## @@ -150,10 +150,12 @@ class ConstIntBoundAnalyzer::Impl : const PrimExprNode* op =

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-20 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r411886246 ## File path: include/tvm/te/operation.h ## @@ -112,6 +113,7 @@ class OperationNode : public tir::FunctionBaseNode { const Operation&

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-20 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r411885530 ## File path: src/arith/int_set.cc ## @@ -730,12 +765,30 @@ Map ConvertDomMap( return dmap; } -IntSet EvalSet(PrimExpr e, -

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5367: Improve IntervalSet's floormod

2020-04-20 Thread GitBox
yongfeng-nv commented on a change in pull request #5367: URL: https://github.com/apache/incubator-tvm/pull/5367#discussion_r411785613 ## File path: src/arith/int_set.cc ## @@ -372,7 +387,27 @@ class IntervalSetEvaluator : } IntervalSet Eval(const PrimExpr& val) { -