[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5578: [Relay][Refactor][std::string --> String] Relay updated with String

[GitBox]

zhiics commented on a change in pull request #5578:
URL: https://github.com/apache/incubator-tvm/pull/5578#discussion_r424893721



##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -580,7 +580,7 @@ class CompileEngineImpl : public CompileEngineNode {
         auto symbol_name = src_func->GetAttr<String>(tvm::attr::kGlobalSymbol);
         CHECK(symbol_name.defined()) << "No external symbol is set for:\n"
                                      << AsText(src_func, false);
-        auto gv = GlobalVar(std::string(symbol_name.value()));
+        auto gv = GlobalVar(String(symbol_name.value()));

Review comment:
       just `GlobalVar(symbol_name)`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org