[GitHub] [incubator-tvm] zhiics commented on pull request #5409: [BYOC] Don't annotate constants

2020-04-28 Thread GitBox
zhiics commented on pull request #5409: URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-620687954 @mbaret yeah, I think that's generally good though. We can probably send an RFC to see if we would break some other things. Otherwise, we can only bake it into

[GitHub] [incubator-tvm] zhiics commented on pull request #5409: [BYOC] Don't annotate constants

2020-04-28 Thread GitBox
zhiics commented on pull request #5409: URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-620674803 Sorry for the late followup. I think both points make sense at certain aspect. @manupa-arm I also think A1 should have been covered by binding constants. Fixing constant