comaniac commented on a change in pull request #8785:
URL: https://github.com/apache/tvm/pull/8785#discussion_r691420715



##########
File path: python/tvm/topi/cuda/batch_matmul.py
##########
@@ -258,11 +260,20 @@ def batch_matmul_int8(cfg, x, y, out_shape=None, 
out_dtype=None):
     out_dtype : Optional[str]
         Specifies the output data type for mixed precision batch matmul.
 
+    transpose_a : Optional[bool] = False
+        Whether the first tensor is in transposed format.
+
+    transpose_b : Optional[bool] = True
+        Whether the second tensor is in transposed format.
+
     Returns
     -------
     output : tvm.te.Tensor
         3-D with shape [batch, M, N]
     """
+    del out_shape

Review comment:
       Is this because this compute doesn't process this? What happen if we 
just leave it as an unused argument? Or we could check if `out_shape` is 
consistent with the inferred output shape and throw a warning if not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to