[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-765001735 Yes, my originally attempt failed a bunch prelude/adt tests because I didn't support that :) This is an

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-21 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665 @jroesch @tmoreau89 Hit a driver bug in a CI node last night than Tianqi fixed, otherwise this passed tests, I think it's ready for review while the rebase runs.

[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types

2021-01-15 Thread GitBox
mbrookhart commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-761220335 Yeah, it's a little weird. I'd like to run through CI just in case I introduced a bug somewhere, but once that's complete I can take a look at unifying the different versions of