[GitHub] incubator-weex pull request #501: [iOS] fix WXCycleSliderComponent initial i...

2017-07-10 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/501#discussion_r126387701 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCycleSliderComponent.m --- @@ -460,6 +460,12 @@ - (void)insertSubview:(WXComponent *)subcomponent

[GitHub] incubator-weex pull request #501: [iOS] WXCycleSliderComponent initial index

2017-07-10 Thread JiaHongXu
GitHub user JiaHongXu opened a pull request: https://github.com/apache/incubator-weex/pull/501 [iOS] WXCycleSliderComponent initial index bug fix: initial index of WXCycleSliderComponent may be incorrect if inserting subviews after layoutDidFinish (occurs when creating

[GitHub] incubator-weex issue #501: [iOS] WXCycleSliderComponent initial index

2017-07-10 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/501 Fails :no_entry_sign: This PR modify SDK code. Please add/modify corresponding testcases. If

[GitHub] incubator-weex pull request #500: [ios] fix WXCycleSliderComponent's initial...

2017-07-10 Thread JiaHongXu
Github user JiaHongXu closed the pull request at: https://github.com/apache/incubator-weex/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-weex pull request #500: 0.15 dev

2017-07-10 Thread JiaHongXu
GitHub user JiaHongXu opened a pull request: https://github.com/apache/incubator-weex/pull/500 0.15 dev bug fix: initial index of WXCycleSliderComponent may be incorrect if inserting subviews after layoutDidFinish (occurs when creating time-consuming subview/components) You

[1/2] incubator-weex git commit: Update common-style.md

2017-07-10 Thread tancy
Repository: incubator-weex Updated Branches: refs/heads/dev 179437521 -> 4742d5d09 Update common-style.md 文案校对 Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/4bcf7cc8 Tree:

[GitHub] incubator-weex pull request #496: Update common-style.md

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[2/2] incubator-weex git commit: Merge branch 'miyalee-patch-1' of https://github.com/miyalee/incubator-weex into dev

2017-07-10 Thread tancy
Merge branch 'miyalee-patch-1' of https://github.com/miyalee/incubator-weex into dev Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/4742d5d0 Tree: