Github user coreycao closed the pull request at:
https://github.com/apache/incubator-weex/pull/956
---
GitHub user coreycao opened a pull request:
https://github.com/apache/incubator-weex/pull/956
* [android] correct the typo of 'show-loading' Constants.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/coreycao/incubator-weex
Github user coreycao commented on the issue:
https://github.com/apache/incubator-weex/pull/687
OK, thanks.
---
Github user coreycao commented on the issue:
https://github.com/apache/incubator-weex/pull/687
@misakuo
Sorry to bother you again, the new PR is here. : )
And I fixed another several tiny bugs in the SDK, should I commit them in
one PR or in seperated PRs ?
---
GitHub user coreycao opened a pull request:
https://github.com/apache/incubator-weex/pull/687
* [android] correct the format of the date returned by pickDate method.
The pickDate method in Android's Picker Module will return date like
'2017-09-6' instead of '2017-09-06', this PR
Github user coreycao closed the pull request at:
https://github.com/apache/incubator-weex/pull/684
---
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137217662
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137216176
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137212527
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view
GitHub user coreycao reopened a pull request:
https://github.com/apache/incubator-weex/pull/684
* [android] correct the format of the date returned by pickDate method.
The pickDate method in Android's Picker Module will return date like
'2017-09-6' instead of '2017-09-06', this PR
GitHub user coreycao opened a pull request:
https://github.com/apache/incubator-weex/pull/684
* [android] correct the format of the date returned by pickDate method.
The pickDate method in Android's Picker Module will return date like
'2017-09-6' instead of '2017-09-06', this PR
11 matches
Mail list logo