* [android] remove 3 methods
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/c643ceaf Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/c643ceaf Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/c643ceaf Branch: refs/heads/release Commit: c643ceafeb284602acc2ea87a0a0cf1dfa5d7854 Parents: 4656959 Author: misakuo <misa...@apache.org> Authored: Wed Sep 27 18:52:02 2017 +0800 Committer: misakuo <misa...@apache.org> Committed: Wed Sep 27 18:52:02 2017 +0800 ---------------------------------------------------------------------- .../weex/ui/view/WXBaseCircleIndicator.java | 40 +++++++++----------- 1 file changed, 18 insertions(+), 22 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/c643ceaf/android/sdk/src/main/java/com/taobao/weex/ui/view/WXBaseCircleIndicator.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXBaseCircleIndicator.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXBaseCircleIndicator.java index 5983f2d..ea4a817 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXBaseCircleIndicator.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXBaseCircleIndicator.java @@ -24,6 +24,7 @@ import android.graphics.Canvas; import android.graphics.Color; import android.graphics.Paint; import android.graphics.Paint.Style; +import android.support.v4.view.ViewPager; import android.support.v4.view.ViewPager.OnPageChangeListener; import android.util.AttributeSet; import android.view.MotionEvent; @@ -34,7 +35,7 @@ import com.taobao.weex.ui.view.gesture.WXGestureObservable; import com.taobao.weex.utils.WXViewUtils; -public class WXBaseCircleIndicator extends FrameLayout implements OnPageChangeListener, WXGestureObservable { +public class WXBaseCircleIndicator extends FrameLayout implements WXGestureObservable { private final Paint mPaintPage = new Paint(); private final Paint mPaintFill = new Paint(); @@ -59,6 +60,8 @@ public class WXBaseCircleIndicator extends FrameLayout implements OnPageChangeLi private int fillColor = Color.DKGRAY; private int realCurrentItem; + private OnPageChangeListener mListener; + public WXBaseCircleIndicator(Context context) { super(context); @@ -91,12 +94,21 @@ public class WXBaseCircleIndicator extends FrameLayout implements OnPageChangeLi } /** - * @param mCircleViewPager the mCircleViewPager to set + * @param viewPager the mCircleViewPager to set */ - public void setCircleViewPager(WXCircleViewPager mCircleViewPager) { - this.mCircleViewPager = mCircleViewPager; - if (this.mCircleViewPager != null) { - this.mCircleViewPager.addOnPageChangeListener(this); + public void setCircleViewPager(WXCircleViewPager viewPager) { + mCircleViewPager = viewPager; + if (mCircleViewPager != null) { + if (mListener == null) { + mListener = new ViewPager.SimpleOnPageChangeListener() { + @Override + public void onPageSelected(int position) { + realCurrentItem = mCircleViewPager.getRealCurrentItem(); + invalidate(); + } + }; + } + this.mCircleViewPager.addOnPageChangeListener(mListener); this.realCurrentItem = mCircleViewPager.getRealCurrentItem(); if (realCurrentItem < 0) { realCurrentItem = 0; @@ -105,22 +117,6 @@ public class WXBaseCircleIndicator extends FrameLayout implements OnPageChangeLi requestLayout(); } - @Override - public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) { - - } - - @Override - public void onPageSelected(int position) { - realCurrentItem = mCircleViewPager.getRealCurrentItem(); - invalidate(); - } - - @Override - public void onPageScrollStateChanged(int state) { - - } - /** * @param radius the radius to set */
