zshshr commented on a change in pull request #2638: [Android] bugfix of the
scrollstart and scrollend event mismatching
URL: https://github.com/apache/incubator-weex/pull/2638#discussion_r299342740
##########
File path:
android/sdk/src/main/java/com/taobao/weex/ui/component/helper/ScrollStartEndHelper.java
##########
@@ -64,14 +67,16 @@ public void onScrolled(int x, int y){
||
component.getEvents().contains(Constants.Event.SCROLL_END))){
this.x = x;
this.y = y;
- if(!hasStart){
+ if(!hasStart && canStart){
Review comment:
code inline 95 is for the case the list has reached the top or bottom that
can not callback in onscroll
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
