Github user coreycao closed the pull request at:
https://github.com/apache/incubator-weex/pull/684
---
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137217662
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
Github user misakuo commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137216945
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137216176
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
Github user misakuo commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137215833
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
Github user coreycao commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137212527
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
Github user misakuo commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/684#discussion_r137211104
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -82,6 +82,7 @@ - (void)viewDidLoad
_webview = (WXWebView *)self.view;
GitHub user coreycao reopened a pull request:
https://github.com/apache/incubator-weex/pull/684
* [android] correct the format of the date returned by pickDate method.
The pickDate method in Android's Picker Module will return date like
'2017-09-6' instead of '2017-09-06', this PR
GitHub user coreycao opened a pull request:
https://github.com/apache/incubator-weex/pull/684
* [android] correct the format of the date returned by pickDate method.
The pickDate method in Android's Picker Module will return date like
'2017-09-6' instead of '2017-09-06', this PR