[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread acton393
Github user acton393 closed the pull request at: https://github.com/apache/incubator-weex/pull/901 ---

[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread CYJB
Github user CYJB commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/901#discussion_r152569045 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXMetaModule.m --- @@ -42,6 +43,31 @@ - (void)setViewport:(NSDictionary *)viewportArguments } else {

[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread CYJB
Github user CYJB commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/901#discussion_r152569002 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXMetaModule.m --- @@ -42,6 +43,31 @@ - (void)setViewport:(NSDictionary *)viewportArguments } else {

[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread acton393
GitHub user acton393 opened a pull request: https://github.com/apache/incubator-weex/pull/901 [WEEX-137][iOS] support iPhone X safe area css env value and set viewport via meta module. [WEEX-137][iOS] support iPhone X safe area css env value and set viewport via meta module.