[incubator-weex] branch master updated: [iOS] Also write js error log to monitor. (#1767)

[cxfeng]

This is an automated email from the ASF dual-hosted git repository.

cxfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
     new 4dfdb0a  [iOS] Also write js error log to monitor. (#1767)
4dfdb0a is described below

commit 4dfdb0a88431c1b18e08b676f7393e2b070a8e4e
Author: wqyfavor <wqyfa...@163.com>
AuthorDate: Thu Nov 22 16:10:19 2018 +0800

    [iOS] Also write js error log to monitor. (#1767)
---
 ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m | 6 +++---
 ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m 
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index 6d42333..811ed62 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -1142,15 +1142,15 @@ _Pragma("clang diagnostic pop") \
         [string appendFormat:@"%@ ", jsVal];
         if (idx == arguments.count - 1) {
             if (logLevel) {
-                if (WXLogFlagWarning == logLevel) {
+                if (WXLogFlagWarning == logLevel || WXLogFlagError == 
logLevel) {
                     id<WXAppMonitorProtocol> appMonitorHandler = [WXSDKEngine 
handlerForProtocol:@protocol(WXAppMonitorProtocol)];
                     if ([appMonitorHandler 
respondsToSelector:@selector(commitAppMonitorAlarm:monitorPoint:success:errorCode:errorMsg:arg:)])
 {
-                        [appMonitorHandler commitAppMonitorAlarm:@"weex" 
monitorPoint:@"jswarning" success:FALSE errorCode:@"99999" errorMsg:string 
arg:[WXSDKEngine topInstance].pageName];
+                        [appMonitorHandler commitAppMonitorAlarm:@"weex" 
monitorPoint:@"jswarning" success:NO errorCode:@"99999" errorMsg:string 
arg:[WXSDKEngine topInstance].pageName];
                     }
                 }
                 WX_LOG(logLevel, @"%@", string);
             } else {
-                [string appendFormat:@"%@ ", jsVal]                            
      ;
+                [string appendFormat:@"%@ ", jsVal];
                 WXLogInfo(@"%@", string);
             }
         }
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm 
b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
index a332abf..78d4b4d 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
@@ -167,16 +167,16 @@ namespace WeexCore
         [arguments enumerateObjectsUsingBlock:^(NSString *jsVal, NSUInteger 
idx, BOOL *stop) {
             if (idx == arguments.count - 1) {
                 if (logLevel) {
-                    if (WXLogFlagWarning == logLevel) {
+                    if (WXLogFlagWarning == logLevel || WXLogFlagError == 
logLevel) {
                         id<WXAppMonitorProtocol> appMonitorHandler = 
[WXSDKEngine handlerForProtocol:@protocol(WXAppMonitorProtocol)];
                         if ([appMonitorHandler 
respondsToSelector:@selector(commitAppMonitorAlarm:monitorPoint:success:errorCode:errorMsg:arg:)])
 {
-                            [appMonitorHandler commitAppMonitorAlarm:@"weex" 
monitorPoint:@"jswarning" success:FALSE errorCode:@"99999" errorMsg:jsLog 
arg:[WXSDKEngine topInstance].pageName];
+                            [appMonitorHandler commitAppMonitorAlarm:@"weex" 
monitorPoint:@"jswarning" success:NO errorCode:@"99999" errorMsg:jsLog 
arg:[WXSDKEngine topInstance].pageName];
                         }
                     }
                     WX_LOG(logLevel, @"%@", jsLog);
                 }
                 else {
-                    [jsLog appendFormat:@"%@ ", jsVal]                         
         ;
+                    [jsLog appendFormat:@"%@ ", jsVal];
                     WXLogInfo(@"%@", jsLog);
                 }
             }