[GitHub] weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1731#issuecomment-437296956 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1731#issuecomment-437296956 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot edited a comment on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1813#issuecomment-441519657 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot edited a comment on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1813#issuecomment-441519657 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot commented on issue #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1813#issuecomment-441519657 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucky-chen opened a new pull request #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception)
lucky-chen opened a new pull request #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception) URL: https://github.com/apache/incubator-weex/pull/1814 errorCode type edit `-2013` is js exception This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blackteachinese closed pull request #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
blackteachinese closed pull request #1731: [WEEX-657][iOS] Add a feature to
control the offset of list attach to…
URL: https://github.com/apache/incubator-weex/pull/1731
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index d6aca1de3f..af73a07fb9 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -1033,6 +1033,7 @@
DCF0CD9E1EAF3A6B0062CA8F /* native-bundle-main.js in Resources
*/ = {isa = PBXBuildFile; fileRef = DCF0CD9D1EAF3A6B0062CA8F /*
native-bundle-main.js */; };
DCF343671E49CAEE00A2FB34 /* WXJSExceptionInfo.h in Headers */ =
{isa = PBXBuildFile; fileRef = DCF343651E49CAEE00A2FB34 /* WXJSExceptionInfo.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
DCF343681E49CAEE00A2FB34 /* WXJSExceptionInfo.m in Sources */ =
{isa = PBXBuildFile; fileRef = DCF343661E49CAEE00A2FB34 /* WXJSExceptionInfo.m
*/; };
+ E6F9D95421A80E780082072E /* WXListComponent_internal.h in
Headers */ = {isa = PBXBuildFile; fileRef = E6F9D95321A80E780082072E /*
WXListComponent_internal.h */; };
ED053500207F4DEB007B4568 /* JSContext+Weex.h in Headers */ =
{isa = PBXBuildFile; fileRef = ED0534FE207F4DEB007B4568 /* JSContext+Weex.h */;
settings = {ATTRIBUTES = (Public, ); }; };
ED053501207F4DEB007B4568 /* JSContext+Weex.h in Headers */ =
{isa = PBXBuildFile; fileRef = ED0534FE207F4DEB007B4568 /* JSContext+Weex.h */;
settings = {ATTRIBUTES = (Public, ); }; };
ED053502207F4DEB007B4568 /* JSContext+Weex.m in Sources */ =
{isa = PBXBuildFile; fileRef = ED0534FF207F4DEB007B4568 /* JSContext+Weex.m */;
};
@@ -1602,6 +1603,7 @@
DCF0CD9D1EAF3A6B0062CA8F /* native-bundle-main.js */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.javascript; name =
"native-bundle-main.js"; path = "../../../../pre-build/native-bundle-main.js";
sourceTree = ""; };
DCF343651E49CAEE00A2FB34 /* WXJSExceptionInfo.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
WXJSExceptionInfo.h; sourceTree = ""; };
DCF343661E49CAEE00A2FB34 /* WXJSExceptionInfo.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path
= WXJSExceptionInfo.m; sourceTree = ""; };
+ E6F9D95321A80E780082072E /* WXListComponent_internal.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
WXListComponent_internal.h; sourceTree = ""; };
ED0534FE207F4DEB007B4568 /* JSContext+Weex.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
"JSContext+Weex.h"; sourceTree = ""; };
ED0534FF207F4DEB007B4568 /* JSContext+Weex.m */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.objc; path =
"JSContext+Weex.m"; sourceTree = ""; };
/* End PBXFileReference section */
@@ -2197,6 +2199,7 @@
37B51EE31E97804D0040A743 /*
WXCycleSliderComponent.mm */,
74CC7A1B1C2BC5F800829368 /* WXCellComponent.mm
*/,
74CC7A1E1C2BF9DC00829368 /* WXListComponent.h
*/,
+ E6F9D95321A80E780082072E /*
WXListComponent_internal.h */,
74CC7A1F1C2BF9DC00829368 /* WXListComponent.mm
*/,
2AC750221C7565690041D390 /*
WXIndicatorComponent.h */,
2AC750231C7565690041D390 /*
WXIndicatorComponent.m */,
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
index a9f18bf1b1..b63231411a 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
@@ -32,6 +32,14 @@
#import "WXRefreshComponent.h"
#import "WXLoadingComponent.h"
+@interface WXListComponent ()
+
+@property (nonatomic, assign) NSUInteger currentTopVisibleSection;
+// Set whether the content offset position all the way to the bottom
+@property (assign, nonatomic) BOOL contentAttachBottom;
+
+@end
+
@interface WXTableView : UITableView
@end
@@ -79,6 +87,19 @@ - (void)setContentOffset:(CGPoint)contentOffset
[super setContentOffset:contentOffset];
}
+- (void)setFrame:(CGRect)frame {
+[super setFrame:frame];
+if (![self.wx_component isKindOfClass:[WXListComponent class]]) return;
+BOOL contentAttachBottom = [(WXListComponent *)self.wx_component
contentAttachBottom];
+if (contentAttachBottom) {
+CGFloat offsetHeight = self.contentSize.height -
[GitHub] win80540 opened a new pull request #1816: [WEEX-669][android] fix slider crash when adapter is null
win80540 opened a new pull request #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816 fix slider crash when adapter is null java.lang.NullPointerException: Attempt to invoke virtual method 'void com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' on a null object reference at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) at com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) at com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6195) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1812: [Android] fix sdk Parser.nextToken malfunction
weex-bot edited a comment on issue #1812: [Android] fix sdk Parser.nextToken malfunction URL: https://github.com/apache/incubator-weex/pull/1812#issuecomment-441499448 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception)
YorkShen closed pull request #1814: [WEEX-668][Android] errorCode type edit
(-2013 is a js exception)
URL: https://github.com/apache/incubator-weex/pull/1814
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
b/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
index aa43bca23b..ff2d6fcea3 100644
--- a/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
+++ b/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
@@ -66,7 +66,7 @@
/**
* Failure for executing JavaScript function.
*/
- WX_ERR_JS_EXECUTE("-2013", "JavaScript execute
error!",ErrorType.NATIVE_ERROR,ErrorGroup.NATIVE),
+ WX_ERR_JS_EXECUTE("-2013", "JavaScript execute
error!",ErrorType.JS_ERROR,ErrorGroup.JS),
/*
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null
weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anrananran commented on issue #1721: weex navigator如何清除导航堆栈
anrananran commented on issue #1721: weex navigator如何清除导航堆栈 URL: https://github.com/apache/incubator-weex/issues/1721#issuecomment-441496583 @songxing1 谢谢，我让他们参考下 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
weex-bot edited a comment on issue #1731: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1731#issuecomment-437296956 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blackteachinese opened a new pull request #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
blackteachinese opened a new pull request #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to… URL: https://github.com/apache/incubator-weex/pull/1813 … the bottom` I have add a '_isContentAttachBottom' attribute in WXListComponent to controll whether open this feature. The Weex Component can pass the ‘_isContentAttachBottom’ variable from js to native by 'initWithRef' and 'updateAttributes' function. The '_isContentAttachBottom' variable will be analysed to a bool type and cached in WXTableView object. When the WXTableView object is called the 'setFrame' function,if the '_isContentAttachBottom' variable is true , then the 'contentOffset' function of WXTableView object will be triggered to keep the content offset at the bottom.When the WXTableView object is running the transition animation, the 'setFrame' will be call every 16 msec . So when the animation is excuting，the content offset of list will be alaways attached to the bottom . feature: 657 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mythbobo commented on issue #1783: video组件能否支持rtsp,rtmp之类的直播流播放？
mythbobo commented on issue #1783: video组件能否支持rtsp,rtmp之类的直播流播放？ URL: https://github.com/apache/incubator-weex/issues/1783#issuecomment-441495307 > There is no plan support in the short term. You are welcome to submit pr 没有android，ios的开发经验。。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Darin726 commented on issue #1803: 0.18.0 libweexjsc.so 异常导致app crash
Darin726 commented on issue #1803: 0.18.0 libweexjsc.so 异常导致app crash URL: https://github.com/apache/incubator-weex/issues/1803#issuecomment-441520089 libweexjsc.so 是你们编译的吗? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Owenli0202 commented on issue #1803: 0.18.0 libweexjsc.so 异常导致app crash
Owenli0202 commented on issue #1803: 0.18.0 libweexjsc.so 异常导致app crash URL: https://github.com/apache/incubator-weex/issues/1803#issuecomment-441528673 不是的 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception)
weex-bot edited a comment on issue #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception) URL: https://github.com/apache/incubator-weex/pull/1814#issuecomment-441529782 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-weex] branch master updated: [WEEX-657][iOS] Add a feature to control the offset of list attach to the bottom` (#1813)
This is an automated email from the ASF dual-hosted git repository.
cxfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new 72440a8 [WEEX-657][iOS] Add a feature to control the offset of list
attach to the bottom` (#1813)
72440a8 is described below
commit 72440a8033e24f74a70e8da4f2cd87bedbb32334
Author: BlackTea
AuthorDate: Mon Nov 26 15:36:21 2018 +0800
[WEEX-657][iOS] Add a feature to control the offset of list attach to the
bottom` (#1813)
I have add a '_isContentAttachBottom' attribute in WXListComponent to
controll whether open this feature. The Weex Component can pass the
‘_isContentAttachBottom’ variable from js to native by 'initWithRef'
and 'updateAttributes' function. The '_isContentAttachBottom' variable
will be analysed to a bool type and cached in WXTableView object.
When the WXTableView object is called the 'setFrame' function,if the
'_isContentAttachBottom' variable is true , then the 'contentOffset'
function of WXTableView object will be triggered to keep the content offset
at the bottom.When the WXTableView object is running the transition
animation, the 'setFrame' will be call every 16 msec . So when the animation
is excuting，the content offset of list will be alaways attached to the
bottom .
feature: 657
---
.../WeexSDK/Sources/Component/WXListComponent.mm | 30 +-
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
index a9f18bf..fe91dfa 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
@@ -32,6 +32,14 @@
#import "WXRefreshComponent.h"
#import "WXLoadingComponent.h"
+@interface WXListComponent ()
+
+@property (nonatomic, assign) NSUInteger currentTopVisibleSection;
+// Set whether the content offset position all the way to the bottom
+@property (assign, nonatomic) BOOL contentAttachBottom;
+
+@end
+
@interface WXTableView : UITableView
@end
@@ -79,6 +87,18 @@
[super setContentOffset:contentOffset];
}
+- (void)setFrame:(CGRect)frame {
+[super setFrame:frame];
+if (![self.wx_component isKindOfClass:[WXListComponent class]]) return;
+BOOL contentAttachBottom = [(WXListComponent *)self.wx_component
contentAttachBottom];
+if (contentAttachBottom) {
+CGFloat offsetHeight = self.contentSize.height -
CGRectGetHeight(self.bounds);
+if (offsetHeight >= 0) {
+[self setContentOffset:CGPointMake(0, offsetHeight) animated:NO];
+}
+}
+}
+
@end
// WXText is a non-public is not permitted
@@ -114,12 +134,6 @@
}
@end
-@interface WXListComponent ()
-
-@property (nonatomic, assign) NSUInteger currentTopVisibleSection;
-
-@end
-
@implementation WXListComponent
{
__weak UITableView * _tableView;
@@ -144,6 +158,7 @@
_completedSections = [NSMutableArray array];
_reloadInterval = attributes[@"reloadInterval"] ? [WXConvert
CGFloat:attributes[@"reloadInterval"]]/1000 : 0;
_updataType = [WXConvert
NSString:attributes[@"updataType"]]?:@"insert";
+_contentAttachBottom = [WXConvert
BOOL:attributes[@"contentAttachBottom"]];
[self fixFlicker];
}
@@ -198,6 +213,9 @@
if (attributes[@"updataType"]) {
_updataType = [WXConvert NSString:attributes[@"updataType"]];
}
+if (attributes[@"contentAttachBottom"]) {
+_contentAttachBottom = [WXConvert
BOOL:attributes[@"contentAttachBottom"]];
+}
}
- (void)setContentSize:(CGSize)contentSize
[GitHub] cxfeng1 closed pull request #1813: [WEEX-657][iOS] Add a feature to control the offset of list attach to…
cxfeng1 closed pull request #1813: [WEEX-657][iOS] Add a feature to control the
offset of list attach to…
URL: https://github.com/apache/incubator-weex/pull/1813
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
index 854aa3a893..f98f9115d9 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
@@ -32,6 +32,14 @@
#import "WXLoadingComponent.h"
#import "WXScrollerComponent+Layout.h"
+@interface WXListComponent ()
+
+@property (nonatomic, assign) NSUInteger currentTopVisibleSection;
+// Set whether the content offset position all the way to the bottom
+@property (assign, nonatomic) BOOL contentAttachBottom;
+
+@end
+
@interface WXTableView : UITableView
@end
@@ -79,6 +87,18 @@ - (void)setContentOffset:(CGPoint)contentOffset
[super setContentOffset:contentOffset];
}
+- (void)setFrame:(CGRect)frame {
+[super setFrame:frame];
+if (![self.wx_component isKindOfClass:[WXListComponent class]]) return;
+BOOL contentAttachBottom = [(WXListComponent *)self.wx_component
contentAttachBottom];
+if (contentAttachBottom) {
+CGFloat offsetHeight = self.contentSize.height -
CGRectGetHeight(self.bounds);
+if (offsetHeight >= 0) {
+[self setContentOffset:CGPointMake(0, offsetHeight) animated:NO];
+}
+}
+}
+
@end
// WXText is a non-public is not permitted
@@ -115,12 +135,6 @@ - (NSString *)description
}
@end
-@interface WXListComponent ()
-
-@property (nonatomic, assign) NSUInteger currentTopVisibleSection;
-
-@end
-
@implementation WXListComponent
{
__weak UITableView * _tableView;
@@ -145,6 +159,7 @@ - (instancetype)initWithRef:(NSString *)ref type:(NSString
*)type styles:(NSDict
_completedSections = [NSMutableArray array];
_reloadInterval = attributes[@"reloadInterval"] ? [WXConvert
CGFloat:attributes[@"reloadInterval"]]/1000 : 0;
_updataType = [WXConvert
NSString:attributes[@"updataType"]]?:@"insert";
+_contentAttachBottom = [WXConvert
BOOL:attributes[@"contentAttachBottom"]];
[self fixFlicker];
}
@@ -199,6 +214,9 @@ - (void)updateAttributes:(NSDictionary *)attributes
if (attributes[@"updataType"]) {
_updataType = [WXConvert NSString:attributes[@"updataType"]];
}
+if (attributes[@"contentAttachBottom"]) {
+_contentAttachBottom = [WXConvert
BOOL:attributes[@"contentAttachBottom"]];
+}
}
- (void)setContentSize:(CGSize)contentSize
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null
weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1812: [Android] fix sdk Parser.nextToken malfunction
weex-bot commented on issue #1812: [Android] fix sdk Parser.nextToken malfunction URL: https://github.com/apache/incubator-weex/pull/1812#issuecomment-441499448 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception)
weex-bot edited a comment on issue #1814: [WEEX-668][Android] errorCode type edit (-2013 is a js exception) URL: https://github.com/apache/incubator-weex/pull/1814#issuecomment-441529782 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix slider crash when adapter is null
YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix
slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236147587
##
File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
##
@@ -214,7 +214,14 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (TextUtils.isEmpty(component.getComponentType())
Review comment:
Change to this?
```
if(!TextUtils.isEmpty(component.getComponentType())&&...&&...){
if (mAdapter != null) {
mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
}
super.setLayout(component);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
