[GitHub] [incubator-weex-site] GoodBaiYu opened a new issue #495: week的线性渐变问题
GoodBaiYu opened a new issue #495: week的线性渐变问题 URL: https://github.com/apache/incubator-weex-site/issues/495 https://weex.apache.org/zh/docs/styles/common-styles.html#%E4%B8%8A%E6%89%8B%E6%A0%B7%E5%BC%8F Weex 目前只支持两种颜色的渐变,渐变方向如下: to right:从左向右渐变 to left:从右向左渐变 to bottom:从上到下渐变 to top:从下到上渐变 to bottom right:从左上角到右下角 to top left:从右下角到左上角 **非常奇怪的问题:为什么没有to bottom left、 to top right两个方向呢?方向不完备** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen opened a new pull request #2897: [Android] Fix ClassCastException in WXComponent.updateProperties()
YorkShen opened a new pull request #2897: [Android] Fix ClassCastException in WXComponent.updateProperties() URL: https://github.com/apache/incubator-weex/pull/2897 ``` java.lang.ClassCastException: java.lang.Object[] cannot be cast to java.lang.String at com.taobao.weex.ui.component.WXComponent.updateProperties(WXComponent.java:710) at com.taobao.weex.ui.component.WXComponent.updateAttrs(WXComponent.java:274) at com.taobao.weex.ui.component.WXComponent.bindData(WXComponent.java:663) at CustomComponent.bindData(InteractiveVideoComponentV2.java:638) at com.taobao.weex.ui.component.WXVContainer.bindData(WXVContainer.java:166) ``` # Brief Description of the PR # Checklist * Demo: * Documentation: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot commented on issue #2897: [Android] Fix ClassCastException in WXComponent.updateProperties()
weex-bot commented on issue #2897: [Android] Fix ClassCastException in WXComponent.updateProperties() URL: https://github.com/apache/incubator-weex/pull/2897#issuecomment-530654784 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 6e0e7ecba2d6858fe31e5b2061090844e0b70227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] snice commented on issue #2888: 为什么Android 升级到weex0.26的时候,之前的项目里面的console.log日志再AndroidStudio打印不出来了
snice commented on issue #2888: 为什么Android 升级到weex0.26的时候,之前的项目里面的console.log日志再AndroidStudio打印不出来了 URL: https://github.com/apache/incubator-weex/issues/2888#issuecomment-530603686 需要用https://weex.apache.org/zh/docs/modules/console-log.html#switchloglevel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] shenhuniurou commented on issue #2895: [Android]点击事件0.26.0
shenhuniurou commented on issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895#issuecomment-530241167 > 我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死,退出APP,在进去又可以了 master分支已经解决这个bug了,你可以拉取master分支的代码自己打包sdk。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] shenhuniurou commented on issue #2895: [Android]点击事件0.26.0
shenhuniurou commented on issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895#issuecomment-530243472 > ![图片](https://user-images.githubusercontent.com/52556048/64673535-01691d80-d4a1-11e9-916e-cf6aff5cae54.png) > 官网的这个源码下下来重新生成SDK就可以了吗 不是0.26的源代码,是master分支的代码。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] LwLuna commented on issue #2895: [Android]点击事件0.26.0
LwLuna commented on issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895#issuecomment-530244960 > > > > ![图片](https://user-images.githubusercontent.com/52556048/64673535-01691d80-d4a1-11e9-916e-cf6aff5cae54.png) > > 官网的这个源码下下来重新生成SDK就可以了吗 > > 不是0.26的源代码,是master分支的代码。 有没有打包好的分享一下啊 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] LwLuna opened a new issue #2895: [Android]点击事件0.26.0
LwLuna opened a new issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895 我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死,退出APP,在进去又可以了 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] LwLuna commented on issue #2895: [Android]点击事件0.26.0
LwLuna commented on issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895#issuecomment-530242446 > > > > 我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死,退出APP,在进去又可以了 > > master分支已经解决这个bug了,你可以拉取master分支的代码自己打包sdk。 https://user-images.githubusercontent.com/52556048/64673535-01691d80-d4a1-11e9-916e-cf6aff5cae54.png这个官网的下下来打包就可以了吗 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] LwLuna commented on issue #2895: [Android]点击事件0.26.0
LwLuna commented on issue #2895: [Android]点击事件0.26.0 URL: https://github.com/apache/incubator-weex/issues/2895#issuecomment-530242202 ![图片](https://user-images.githubusercontent.com/52556048/64673535-01691d80-d4a1-11e9-916e-cf6aff5cae54.png) 官网的这个源码下下来重新生成SDK就可以了吗 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2845: weex安卓应用的字体类型能不能与手机的字体类型一致
YorkShen closed issue #2845: weex安卓应用的字体类型能不能与手机的字体类型一致 URL: https://github.com/apache/incubator-weex/issues/2845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2845: weex安卓应用的字体类型能不能与手机的字体类型一致
YorkShen commented on issue #2845: weex安卓应用的字体类型能不能与手机的字体类型一致 URL: https://github.com/apache/incubator-weex/issues/2845#issuecomment-530302780 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > Question Description: Can the font type of the weex Android app be the same as the font type of the phone? First of all, there is no font called system font. If you don't specify a font-family, the fallback/default rule of font is undefined behavior. So, specify a [font-family](https://weex.apache.org/docs/styles/text-styles.html#font-family) will make your life easier. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2859: [iOS] XCode11打包,iOS13系统手机,使用组件,字体非苹果默认的苹方字体
YorkShen closed issue #2859: [iOS] XCode11打包,iOS13系统手机,使用组件,字体非苹果默认的苹方字体 URL: https://github.com/apache/incubator-weex/issues/2859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2859: [iOS] XCode11打包,iOS13系统手机,使用组件,字体非苹果默认的苹方字体
YorkShen commented on issue #2859: [iOS] XCode11打包,iOS13系统手机,使用组件,字体非苹果默认的苹方字体 URL: https://github.com/apache/incubator-weex/issues/2859#issuecomment-530313175 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > [iOS] XCode11 package, iOS13 system phone, use component, font is not Apple's default apple font Change it to whatever you want by using [font-family](https://weex.apache.org/docs/styles/text-styles.html#font-family) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2843: W/NetworkEventReporter: java.lang.ClassNotFoundException: com.taobao.weex.devtools.inspector.network.NetworkEventReporterImpl
YorkShen commented on issue #2843: W/NetworkEventReporter: java.lang.ClassNotFoundException: com.taobao.weex.devtools.inspector.network.NetworkEventReporterImpl URL: https://github.com/apache/incubator-weex/issues/2843#issuecomment-530326599 `com.taobao.weex.devtools.inspector.network.NetworkEvent` is imported from `weex_inspection` for debugging purpose. Currently, weex_inspection is not a part of Apache Weex, so you should either remove the dependency or ask question in their [repo](https://github.com/weexteam/android-devtools-for-Apache-Weex) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2843: W/NetworkEventReporter: java.lang.ClassNotFoundException: com.taobao.weex.devtools.inspector.network.NetworkEventReporterImpl
YorkShen closed issue #2843: W/NetworkEventReporter: java.lang.ClassNotFoundException: com.taobao.weex.devtools.inspector.network.NetworkEventReporterImpl URL: https://github.com/apache/incubator-weex/issues/2843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2833: [Android] Android SDK custom WXComponent, there are multiple properties defined using @WXComponentProp, how do I know when all properties a
YorkShen commented on issue #2833: [Android] Android SDK custom WXComponent, there are multiple properties defined using @WXComponentProp, how do I know when all properties are passed from JS to native? URL: https://github.com/apache/incubator-weex/issues/2833#issuecomment-530334936 You can combine multiple properties into one. ``` @WXComponentProp(name = "lottie") public void setLoop(final com.alibaba.fastjson.JSONObjcet map) { } ``` ``` export default { data () { return { lottie: { key_A: value_A, key_B: value_B } } } } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2833: [Android] Android SDK custom WXComponent, there are multiple properties defined using @WXComponentProp, how do I know when all properties are pas
YorkShen closed issue #2833: [Android] Android SDK custom WXComponent, there are multiple properties defined using @WXComponentProp, how do I know when all properties are passed from JS to native? URL: https://github.com/apache/incubator-weex/issues/2833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2890: Any reason for READ_PHONE_STATE permission?
YorkShen commented on issue #2890: Any reason for READ_PHONE_STATE permission? URL: https://github.com/apache/incubator-weex/issues/2890#issuecomment-530311895 Get IMEI of user's phone. As you might observed, `WXEnvironment.getDevId()` is always be invoked no matter you specify `android:name="android.permission.READ_PHONE_STATE` or not since very early version of Weex. In some phone, calling `getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId()` in code without corresponding `AndroidManifest` will cause crash. I just updated the Manifest to prevent possible crash. https://github.com/apache/incubator-weex/blob/24a30b31e759343668cfe6b8f3de264dd3f586fe/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java#L404-L405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2890: Any reason for READ_PHONE_STATE permission?
YorkShen closed issue #2890: Any reason for READ_PHONE_STATE permission? URL: https://github.com/apache/incubator-weex/issues/2890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2863: [Android] wx_create_instance_error, reportJSException >>>> instanceId:3, exception function:createInstance, exception:Exception: ReferenceE
YorkShen commented on issue #2863: [Android] wx_create_instance_error, reportJSException instanceId:3, exception function:createInstance, exception:Exception: ReferenceError: Can't find variable: window URL: https://github.com/apache/incubator-weex/issues/2863#issuecomment-530325509 The log is pretty straight-forward, there is an undefined variable called `window` in your JS file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2863: [Android] wx_create_instance_error, reportJSException >>>> instanceId:3, exception function:createInstance, exception:Exception: ReferenceError:
YorkShen closed issue #2863: [Android] wx_create_instance_error, reportJSException instanceId:3, exception function:createInstance, exception:Exception: ReferenceError: Can't find variable: window URL: https://github.com/apache/incubator-weex/issues/2863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2844: [Android] webview 引用H5地图定不了位
YorkShen closed issue #2844: [Android] webview 引用H5地图定不了位 URL: https://github.com/apache/incubator-weex/issues/2844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2844: [Android] webview 引用H5地图定不了位
YorkShen commented on issue #2844: [Android] webview 引用H5地图定不了位 URL: https://github.com/apache/incubator-weex/issues/2844#issuecomment-530301074 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > Question Description: [Android] webview reference H5 map can not be bit According to [our document](https://weex.apache.org/docs/components/web.html#summary), webview is only for degraded scenario, you should not use webview in normal user case. > `` is only used as a degraded unconventional scenario and is not recommended for a large number of normal Weex pages. So, this problem won't be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2852: 0.20版本windows打包和mac打包发现apk大小不一致!大佬们什么原因
YorkShen closed issue #2852: 0.20版本windows打包和mac打包发现apk大小不一致!大佬们什么原因 URL: https://github.com/apache/incubator-weex/issues/2852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2860: 有富文本编辑组件吗?
YorkShen commented on issue #2860: 有富文本编辑组件吗? URL: https://github.com/apache/incubator-weex/issues/2860#issuecomment-530312439 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > Question Description: Is there a rich text editing component? Nope, and you're welcomed to give us PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2860: 有富文本编辑组件吗?
YorkShen closed issue #2860: 有富文本编辑组件吗? URL: https://github.com/apache/incubator-weex/issues/2860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-weex] branch optimize-tlog created (now 3adeb8a)
This is an automated email from the ASF dual-hosted git repository. moshen pushed a change to branch optimize-tlog in repository https://gitbox.apache.org/repos/asf/incubator-weex.git. at 3adeb8a Optimize iOS logs. This branch includes the following new commits: new 3adeb8a Optimize iOS logs. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[incubator-weex] 01/01: Optimize iOS logs.
This is an automated email from the ASF dual-hosted git repository. moshen pushed a commit to branch optimize-tlog in repository https://gitbox.apache.org/repos/asf/incubator-weex.git commit 3adeb8a1d4c1e6d36aadea50e15944243867298c Author: qianyuan.wqy AuthorDate: Wed Sep 11 18:35:56 2019 +0800 Optimize iOS logs. --- ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m | 5 ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m | 14 ++- .../WeexSDK/Sources/Performance/WXApmForInstance.m | 1 + weex_core/Source/core/bridge/script_bridge.h | 1 - .../render/action/render_action_createfinish.cpp | 1 - .../Source/core/render/manager/render_manager.cpp | 28 ++ 6 files changed, 37 insertions(+), 13 deletions(-) diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m index c53229d..207abab 100644 --- a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m +++ b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m @@ -530,6 +530,8 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* - (void)registerService:(NSString *)name withService:(NSString *)serviceScript withOptions:(NSDictionary *)options completion:(void(^)(BOOL result))completion { +WXLogInfo(@"Register service: %@, options: %@", name, options); + if (!name || !serviceScript || !options) { if (completion) { completion(NO); @@ -557,6 +559,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* { if (!name) return; +WXLogInfo(@"Unregister service: %@", name); NSString *script = [WXServiceFactory unregisterServiceScript:name]; __weak typeof(self) weakSelf = self; @@ -575,6 +578,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* if (!modules) return; modules = [WXUtility convertContainerToImmutable:modules]; +WXLogInfo(@"Register modules: %@", modules); __weak typeof(self) weakSelf = self; WXPerformBlockOnBridgeThread(^(){ @@ -590,6 +594,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* if (!components) return; components = [WXUtility convertContainerToImmutable:components]; +WXLogInfo(@"Register components: %@", components); __weak typeof(self) weakSelf = self; WXPerformBlockOnBridgeThread(^(){ diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m index 0bcda66..1824b13 100644 --- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m +++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m @@ -124,6 +124,8 @@ typedef enum : NSUInteger { } } +WXLogInfo(@"Create instance: %@, render type: %@", _instanceId, _renderType); + // TODO self is retained here. [WXSDKManager storeInstance:self forID:_instanceId]; @@ -206,6 +208,12 @@ typedef enum : NSUInteger { return [NSString stringWithFormat:@"<%@: %p; id = %@; rootView = %p; url= %@>", NSStringFromClass([self class]), self, _instanceId, (__bridge void*)_rootView, _scriptURL]; } +- (void)setParentInstance:(WXSDKInstance *)parentInstance +{ +WXLogInfo(@"Embed instance %@ into parent instance %@", _instanceId, parentInstance.instanceId); +_parentInstance = parentInstance; +} + #pragma mark Public Mehtods - (UIView *)rootView @@ -710,12 +718,13 @@ typedef enum : NSUInteger { }; _mainBundleLoader.onFailed = ^(NSError *loadError) { +WXLogError(@"Request failed with error: %@", loadError); + NSString *errorMessage = [NSString stringWithFormat:@"Request to %@ occurs an error:%@, info:%@", request.URL, loadError.localizedDescription, loadError.userInfo]; long wxErrorCode = [loadError.domain isEqualToString:NSURLErrorDomain] && loadError.code == NSURLErrorNotConnectedToInternet ? WX_ERR_NOT_CONNECTED_TO_INTERNET : WX_ERR_JSBUNDLE_DOWNLOAD; WX_MONITOR_FAIL_ON_PAGE(WXMTJSDownload, wxErrorCode, errorMessage, weakSelf.pageName); - NSMutableDictionary *allUserInfo = [[NSMutableDictionary alloc] initWithDictionary:error.userInfo]; [allUserInfo addEntriesFromDictionary:loadError.userInfo]; NSError *errorWithReportMsg = [NSError errorWithDomain:error.domain @@ -766,6 +775,8 @@ typedef enum : NSUInteger { - (void)destroyInstance { +WXLogInfo(@"Destroy instance: %@", _instanceId); + [self.apmInstance endRecord]; NSString *url = @""; if ([WXPrerenderManager isTaskExist:[self.scriptURL absoluteString]]) { @@ -810,6 +821,7 @@ typedef enum : NSUInteger { // Reading config from orange for Release instance in Main Thread or not, for Bug #15172691 +{ dispatch_async(dispatch_get_main_queue(), ^{ [WXSDKManager removeInstanceforID:instanceId]; +
[GitHub] [incubator-weex] wqyfavor opened a new pull request #2896: Optimize iOS logs.
wqyfavor opened a new pull request #2896: Optimize iOS logs. URL: https://github.com/apache/incubator-weex/pull/2896 # Brief Description of the PR # Checklist * Demo: * Documentation: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2820: [Android][honer 8] compiler error in weex 0.24 on cmake3.6.4111459 && ndk-bundle/r16
YorkShen closed issue #2820: [Android][honer 8] compiler error in weex 0.24 on cmake3.6.4111459 && ndk-bundle/r16 URL: https://github.com/apache/incubator-weex/issues/2820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2820: [Android][honer 8] compiler error in weex 0.24 on cmake3.6.4111459 && ndk-bundle/r16
YorkShen commented on issue #2820: [Android][honer 8] compiler error in weex 0.24 on cmake3.6.4111459 && ndk-bundle/r16 URL: https://github.com/apache/incubator-weex/issues/2820#issuecomment-530301560 Try to compile source code in master branch with ndk 18, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2886: 64bit support for x86 arch
YorkShen commented on issue #2886: 64bit support for x86 arch URL: https://github.com/apache/incubator-weex/issues/2886#issuecomment-530304982 Currently, I can't give you a timeline about supporting `x86-64` as most of users run Apps with `armv8-64` phone instead of `x86-64`. The main problem here is compiling [JSC](https://github.com/alibaba/weex_js_engine/tree/bridge_branch_mergeTimer) (a dependency of Weex) for x86-64 ABI. So far, no progress. You're welcomed to help us solve the problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2886: 64bit support for x86 arch
YorkShen closed issue #2886: 64bit support for x86 arch URL: https://github.com/apache/incubator-weex/issues/2886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2852: 0.20版本windows打包和mac打包发现apk大小不一致!大佬们什么原因
YorkShen commented on issue #2852: 0.20版本windows打包和mac打包发现apk大小不一致!大佬们什么原因 URL: https://github.com/apache/incubator-weex/issues/2852#issuecomment-530308381 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > Question Description: 0.20 version of windows packaging and mac packaging found apk size is inconsistent! What are the reasons for us? I can't tell you what happened exactly as I am not a committer of NDK, but generally speaking, this problem is caused by stripping. As you can see, the size of many shared libraries are different, not only Weex. Change `/armeabi-v7a/.so` to `/armeabi-v7a/*.so` will give you what you want. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2874: weex 的indicator组件能不能设置宽高以及背景颜色
YorkShen commented on issue #2874: weex 的indicator组件能不能设置宽高以及背景颜色 URL: https://github.com/apache/incubator-weex/issues/2874#issuecomment-530325108 感谢你的反馈,Weex目前是隶属于Apache Software Foundation的项目,因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语,并以英语回答。 > Question Description: Weex's indicator component can set the width and height as well as the background color You're welcomed to give a PR. Please remember that in Apache Community, the relationship between users and committers are not employer and employee. Participant is always encouraged and you can be Apache committer if you make enough contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2874: weex 的indicator组件能不能设置宽高以及背景颜色
YorkShen closed issue #2874: weex 的indicator组件能不能设置宽高以及背景颜色 URL: https://github.com/apache/incubator-weex/issues/2874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2753: Can I use vuetify + weex?
YorkShen commented on issue #2753: Can I use vuetify + weex? URL: https://github.com/apache/incubator-weex/issues/2753#issuecomment-530328420 I am not familiar with vuetify, but all the vue syntax that Weex supports is listed [here](https://weex.apache.org/guide/use-vue-in-weex.html) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2753: Can I use vuetify + weex?
YorkShen closed issue #2753: Can I use vuetify + weex? URL: https://github.com/apache/incubator-weex/issues/2753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot commented on issue #2896: Optimize iOS logs.
weex-bot commented on issue #2896: Optimize iOS logs. URL: https://github.com/apache/incubator-weex/pull/2896#issuecomment-530328105 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 3adeb8a1d4c1e6d36aadea50e15944243867298c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-weex] branch master updated: Optimize iOS logs. (#2896)
This is an automated email from the ASF dual-hosted git repository. jianhan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-weex.git The following commit(s) were added to refs/heads/master by this push: new 4ce557b Optimize iOS logs. (#2896) 4ce557b is described below commit 4ce557b6dc8e111381e2834b390f450a37796d71 Author: wqyfavor AuthorDate: Wed Sep 11 19:17:55 2019 +0800 Optimize iOS logs. (#2896) --- ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m | 5 ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m | 14 ++- .../WeexSDK/Sources/Performance/WXApmForInstance.m | 1 + weex_core/Source/core/bridge/script_bridge.h | 1 - .../render/action/render_action_createfinish.cpp | 1 - .../Source/core/render/manager/render_manager.cpp | 28 ++ 6 files changed, 37 insertions(+), 13 deletions(-) diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m index c53229d..207abab 100644 --- a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m +++ b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m @@ -530,6 +530,8 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* - (void)registerService:(NSString *)name withService:(NSString *)serviceScript withOptions:(NSDictionary *)options completion:(void(^)(BOOL result))completion { +WXLogInfo(@"Register service: %@, options: %@", name, options); + if (!name || !serviceScript || !options) { if (completion) { completion(NO); @@ -557,6 +559,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* { if (!name) return; +WXLogInfo(@"Unregister service: %@", name); NSString *script = [WXServiceFactory unregisterServiceScript:name]; __weak typeof(self) weakSelf = self; @@ -575,6 +578,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* if (!modules) return; modules = [WXUtility convertContainerToImmutable:modules]; +WXLogInfo(@"Register modules: %@", modules); __weak typeof(self) weakSelf = self; WXPerformBlockOnBridgeThread(^(){ @@ -590,6 +594,7 @@ void WXPerformBlockSyncOnBridgeThreadForInstance(void (^block) (void), NSString* if (!components) return; components = [WXUtility convertContainerToImmutable:components]; +WXLogInfo(@"Register components: %@", components); __weak typeof(self) weakSelf = self; WXPerformBlockOnBridgeThread(^(){ diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m index 0bcda66..1824b13 100644 --- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m +++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m @@ -124,6 +124,8 @@ typedef enum : NSUInteger { } } +WXLogInfo(@"Create instance: %@, render type: %@", _instanceId, _renderType); + // TODO self is retained here. [WXSDKManager storeInstance:self forID:_instanceId]; @@ -206,6 +208,12 @@ typedef enum : NSUInteger { return [NSString stringWithFormat:@"<%@: %p; id = %@; rootView = %p; url= %@>", NSStringFromClass([self class]), self, _instanceId, (__bridge void*)_rootView, _scriptURL]; } +- (void)setParentInstance:(WXSDKInstance *)parentInstance +{ +WXLogInfo(@"Embed instance %@ into parent instance %@", _instanceId, parentInstance.instanceId); +_parentInstance = parentInstance; +} + #pragma mark Public Mehtods - (UIView *)rootView @@ -710,12 +718,13 @@ typedef enum : NSUInteger { }; _mainBundleLoader.onFailed = ^(NSError *loadError) { +WXLogError(@"Request failed with error: %@", loadError); + NSString *errorMessage = [NSString stringWithFormat:@"Request to %@ occurs an error:%@, info:%@", request.URL, loadError.localizedDescription, loadError.userInfo]; long wxErrorCode = [loadError.domain isEqualToString:NSURLErrorDomain] && loadError.code == NSURLErrorNotConnectedToInternet ? WX_ERR_NOT_CONNECTED_TO_INTERNET : WX_ERR_JSBUNDLE_DOWNLOAD; WX_MONITOR_FAIL_ON_PAGE(WXMTJSDownload, wxErrorCode, errorMessage, weakSelf.pageName); - NSMutableDictionary *allUserInfo = [[NSMutableDictionary alloc] initWithDictionary:error.userInfo]; [allUserInfo addEntriesFromDictionary:loadError.userInfo]; NSError *errorWithReportMsg = [NSError errorWithDomain:error.domain @@ -766,6 +775,8 @@ typedef enum : NSUInteger { - (void)destroyInstance { +WXLogInfo(@"Destroy instance: %@", _instanceId); + [self.apmInstance endRecord]; NSString *url = @""; if ([WXPrerenderManager isTaskExist:[self.scriptURL absoluteString]]) { @@ -810,6 +821,7 @@ typedef enum : NSUInteger { // Reading config from orange for Release instance in Main Thread or not, for Bug
[GitHub] [incubator-weex] jianhan-he merged pull request #2896: Optimize iOS logs.
jianhan-he merged pull request #2896: Optimize iOS logs. URL: https://github.com/apache/incubator-weex/pull/2896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2837: [Android] weex page render error:1001 on device 4.4 version is 0.26.0
YorkShen closed issue #2837: [Android] weex page render error:1001 on device 4.4 version is 0.26.0 URL: https://github.com/apache/incubator-weex/issues/2837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2837: [Android] weex page render error:1001 on device 4.4 version is 0.26.0
YorkShen commented on issue #2837: [Android] weex page render error:1001 on device 4.4 version is 0.26.0 URL: https://github.com/apache/incubator-weex/issues/2837#issuecomment-530356316 Please follow the issue template and provide demo on [dotwe](http://dotwe.org/vue). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2881: [Android] Unexpected crash when app is in profiler started state where weex version is 0.26.2
YorkShen commented on issue #2881: [Android] Unexpected crash when app is in profiler started state where weex version is 0.26.2 URL: https://github.com/apache/incubator-weex/issues/2881#issuecomment-530339120 If the crash only happens during profile, it's probably because the profiler tools. There is nothing I can do with such tools. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2881: [Android] Unexpected crash when app is in profiler started state where weex version is 0.26.2
YorkShen closed issue #2881: [Android] Unexpected crash when app is in profiler started state where weex version is 0.26.2 URL: https://github.com/apache/incubator-weex/issues/2881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2819: [Android][AAB]使用Google Play的AAB打包,出现页面渲染失败
YorkShen commented on issue #2819: [Android][AAB]使用Google Play的AAB打包,出现页面渲染失败 URL: https://github.com/apache/incubator-weex/issues/2819#issuecomment-530359645 Weex initlization failed due to there is no corresponding shared library. ``` JavaScriptCore's Path is /data/app/com.hellotalk-DLJZ9th0DAMmVtmO8JE5Iw==/split_config.arm64_v8a.apk!/lib/arm64-v8a/libJavaScriptCore.so but file does not exist ``` Maybe you should check the above log. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2819: [Android][AAB]使用Google Play的AAB打包,出现页面渲染失败
YorkShen closed issue #2819: [Android][AAB]使用Google Play的AAB打包,出现页面渲染失败 URL: https://github.com/apache/incubator-weex/issues/2819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2839: 求分享JS service内置包的方案
YorkShen closed issue #2839: 求分享JS service内置包的方案 URL: https://github.com/apache/incubator-weex/issues/2839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2839: 求分享JS service内置包的方案
YorkShen commented on issue #2839: 求分享JS service内置包的方案 URL: https://github.com/apache/incubator-weex/issues/2839#issuecomment-530355342 It seems like this problem is solved, I will just close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen closed issue #2811: How to get CSSNode(like) in weex 0.26 for android?
YorkShen closed issue #2811: How to get CSSNode(like) in weex 0.26 for android? URL: https://github.com/apache/incubator-weex/issues/2811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #2811: How to get CSSNode(like) in weex 0.26 for android?
YorkShen commented on issue #2811: How to get CSSNode(like) in weex 0.26 for android? URL: https://github.com/apache/incubator-weex/issues/2811#issuecomment-530361481 The `CSSNode` is removed for historical Facebook additional patten reason, read [document](https://weex.apache.org/guide/extend/extend-android.html#component-extension-adaptation) to find out the behaviour. If this could solve your problem, you can update the documentation of Weex to help others. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] Hanks10100 commented on issue #2893: [Android] The cell/cell-slot in the list/recycle-list component of weex cannot be used with vue :is dynamic component usage, not in the l
Hanks10100 commented on issue #2893: [Android] The cell/cell-slot in the list/recycle-list component of weex cannot be used with vue :is dynamic component usage, not in the list component is normal URL: https://github.com/apache/incubator-weex/issues/2893#issuecomment-530382565 The `:is` property is equal with `v-bind:is` which takes a js variable as its value, not the string literal of component name. Remove the `:` or binding it with a js variable can solve it. ```html ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] Hanks10100 closed issue #2893: [Android] The cell/cell-slot in the list/recycle-list component of weex cannot be used with vue :is dynamic component usage, not in the list co
Hanks10100 closed issue #2893: [Android] The cell/cell-slot in the list/recycle-list component of weex cannot be used with vue :is dynamic component usage, not in the list component is normal URL: https://github.com/apache/incubator-weex/issues/2893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services