[incubator-weex] branch master updated: Revert "[Android] Android] restart weexCoreThread when reload JSEngine because thread maybe in lock state and can't execute reload action (block) (#2824)" (#282

2019-08-14 Thread dongyayun
This is an automated email from the ASF dual-hosted git repository.

dongyayun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
 new 36fdc33  Revert "[Android] Android] restart weexCoreThread when reload 
JSEngine because thread maybe in lock state and can't execute reload action 
(block) (#2824)" (#2829)
36fdc33 is described below

commit 36fdc330c66f9fc7fcbbba83703008d563f804b4
Author: chen 
AuthorDate: Thu Aug 15 12:21:48 2019 +0800

Revert "[Android] Android] restart weexCoreThread when reload JSEngine 
because thread maybe in lock state and can't execute reload action (block) 
(#2824)" (#2829)

This reverts commit c72e6b5a833f66ed048042d1e4fb385aa61ed97c.
---
 .../java/com/taobao/weex/bridge/WXBridgeManager.java  | 19 ---
 1 file changed, 19 deletions(-)

diff --git 
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java 
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index 145730c..91aba2a 100755
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -867,14 +867,6 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
 
   }
 
-  public void restartWeexCoreThread(){
-  WXLogUtils.e("weex","restartWeexCoreThread");
-  WXThread oldThread = mJSThread;
-  mJSThread = new WXThread("WeexJSBridgeThread", this);
-  mJSHandler = mJSThread.getHandler();
-  oldThread.quit();
-  }
-
   public int callReportCrashReloadPage(String instanceId, String crashFile) {
 boolean isCrashFileEmpty = TextUtils.isEmpty(crashFile);
 try {
@@ -926,17 +918,6 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
   if (WXSDKManager.getInstance().getSDKInstance(instanceId) != null) {
 boolean reloadThisInstance = shouldReloadCurrentInstance(
 
WXSDKManager.getInstance().getSDKInstance(instanceId).getBundleUrl());
-boolean restartCoreThread = true;
-IWXConfigAdapter adapter = 
WXSDKManager.getInstance().getWxConfigAdapter();
-if (null != adapter){
-String config = 
adapter.getConfig("wxapm","restartCoreThread","true");
-restartCoreThread = Boolean.valueOf(config);
-}
-if (restartCoreThread){
-  WXBridgeManager.getInstance().restartWeexCoreThread();
-}
-
WXSDKManager.getInstance().getSDKInstance(instanceId).getContainerInfo()
-.put("restartWeexCoreThread",String.valueOf(restartCoreThread));
 new ActionReloadPage(instanceId, reloadThisInstance).executeAction();
   }
 



[GitHub] [incubator-weex] Darin726 merged pull request #2829: Revert "[Android] Android] restart weexCoreThread when reload JSEngin…

2019-08-14 Thread GitBox
Darin726 merged pull request #2829: Revert "[Android] Android] restart 
weexCoreThread when reload JSEngin…
URL: https://github.com/apache/incubator-weex/pull/2829
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-weex] branch master updated: [iOS] add flag of grey bundle (#2828)

2019-08-14 Thread luckychen
This is an automated email from the ASF dual-hosted git repository.

luckychen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
 new 84c3bb9  [iOS] add flag of grey bundle (#2828)
84c3bb9 is described below

commit 84c3bb9e6b9ee7f58d4b8563a15c4f39a8ee2e3c
Author: jianhan-he <41508406+jianhan...@users.noreply.github.com>
AuthorDate: Thu Aug 15 11:43:48 2019 +0800

[iOS] add flag of grey bundle (#2828)
---
 ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h | 1 +
 ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m | 6 ++
 2 files changed, 7 insertions(+)

diff --git a/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h 
b/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h
index 335b639..b843c64 100644
--- a/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h
+++ b/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h
@@ -32,6 +32,7 @@ extern NSString* const KEY_PAGE_PROPERTIES_JSLIB_VERSION;
 extern NSString* const KEY_PAGE_PROPERTIES_WEEX_VERSION;
 extern NSString* const KEY_PAGE_PROPERTIES_REQUEST_TYPE;
 extern NSString* const KEY_PAGE_PROPERTIES_Z_CACHE_INFO;
+extern NSString* const KEY_PAGE_PROPERTIES_GREY_BUNDLE;
 extern NSString* const KEY_PAGE_PROPERTIES_JS_FM_INIT;
 extern NSString* const KEY_PAGE_PROPERTIES_BUNDLE_TYPE;
 extern NSString* const KEY_PAGE_PROPERTIES_CONTAINER_NAME;
diff --git a/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m 
b/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m
index 1966b8d..33d6b4b 100644
--- a/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m
+++ b/ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m
@@ -44,6 +44,7 @@ NSString* const KEY_PAGE_PROPERTIES_JSLIB_VERSION  = 
@"wxJSLibVersion";
 NSString* const KEY_PAGE_PROPERTIES_WEEX_VERSION  = @"wxSDKVersion";
 NSString* const KEY_PAGE_PROPERTIES_REQUEST_TYPE  = @"wxRequestType";
 NSString* const KEY_PAGE_PROPERTIES_Z_CACHE_INFO  = @"wxZCacheInfo";
+NSString* const KEY_PAGE_PROPERTIES_GREY_BUNDLE = @"wxGreyBundle";
 NSString* const KEY_PAGE_PROPERTIES_JS_FM_INIT  = @"wxJsFrameworkInit";
 NSString* const KEY_PAGE_PROPERTIES_BUNDLE_TYPE = @"wxBundleType";
 NSString* const KEY_PAGE_PROPERTIES_CONTAINER_NAME = @"wxContainerName";
@@ -441,6 +442,11 @@ NSString* const VALUE_ERROR_CODE_DEFAULT = @"0";
 return;
 }
 
+id wxGreyBundle = [extInfo objectForKey:KEY_PAGE_PROPERTIES_GREY_BUNDLE];
+if (nil != wxGreyBundle && [wxGreyBundle isKindOfClass:NSString.class]) {
+[self setProperty:KEY_PAGE_PROPERTIES_GREY_BUNDLE 
withValue:wxGreyBundle];
+}
+
 id wxRequestType = [extInfo objectForKey:KEY_PAGE_PROPERTIES_REQUEST_TYPE];
 if (nil != wxRequestType && [wxRequestType isKindOfClass: NSString.class]) 
{
 [self setProperty:KEY_PAGE_PROPERTIES_REQUEST_TYPE 
withValue:wxRequestType];



[GitHub] [incubator-weex] lucky-chen merged pull request #2828: [iOS] add flag of grey bundle

2019-08-14 Thread GitBox
lucky-chen merged pull request #2828: [iOS] add flag of grey bundle
URL: https://github.com/apache/incubator-weex/pull/2828
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2829: Revert "[Android] Android] restart weexCoreThread when reload JSEngin…

2019-08-14 Thread GitBox
weex-bot commented on issue #2829: Revert "[Android] Android] restart 
weexCoreThread when reload JSEngin…
URL: https://github.com/apache/incubator-weex/pull/2829#issuecomment-521501778
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
96f05bd6a64c3473960e456b1647ab3c700c24c2
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen opened a new pull request #2829: Revert "[Android] Android] restart weexCoreThread when reload JSEngin…

2019-08-14 Thread GitBox
lucky-chen opened a new pull request #2829: Revert "[Android] Android] restart 
weexCoreThread when reload JSEngin…
URL: https://github.com/apache/incubator-weex/pull/2829
 
 
   Revert https://github.com/apache/incubator-weex/pull/2824 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2828: [iOS] add flag of grey bundle

2019-08-14 Thread GitBox
weex-bot commented on issue #2828: [iOS] add flag of grey bundle
URL: https://github.com/apache/incubator-weex/pull/2828#issuecomment-521498074
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
e13aa43e908b229471be1efd2a2052dfa0f9a700
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] jianhan-he opened a new pull request #2828: [iOS] add flag of grey bundle

2019-08-14 Thread GitBox
jianhan-he opened a new pull request #2828: [iOS] add flag of grey bundle
URL: https://github.com/apache/incubator-weex/pull/2828
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-weex] branch master updated: [Android] Fix Android JNI Crash (#2827)

2019-08-14 Thread luckychen
This is an automated email from the ASF dual-hosted git repository.

luckychen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
 new 7e54ac5  [Android] Fix Android JNI Crash (#2827)
7e54ac5 is described below

commit 7e54ac5c10bc93b8d72659d7dc9b5faa84753f5d
Author: YorkShen 
AuthorDate: Thu Aug 15 10:22:38 2019 +0800

[Android] Fix Android JNI Crash (#2827)

* [Android] Fix Android JNI Crash

`jni_object()` in `ReportException()` could be nullptr if `InitFramework()` 
is not invoked.

```
JNI DETECTED ERROR IN APPLICATION: obj == null
 in call to CallVoidMethodV
from int 
com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(java.lang.String, 
java.lang.String, java.lang.String, com.taobao.weex.bridge.WXJSObject[])
..

(_JNIEnv::CallVoidMethod(_jobject*, _jmethodID*, ...)+22)
(WeexCore::WXBridge::ReportException(_JNIEnv*, char const*, char const*, 
char const*)+132)
 (WeexCore::AndroidSide::ReportException(char const*, char const*, char 
const*)+34)
..

(WeexCore::CoreSideInPlatform::CreateInstance(char const*, char const*, 
char const*, int, char const*, char const*, char const*, 
std::__ndk1::vector>&, char const*)+820)
at com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(Native 
method)
at com.taobao.weex.bridge.WXBridge.createInstanceContext(Taobao:233)
at 
com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstanceContext(Taobao:1981)
at com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstance(Taobao:1709)
```

* Fix crash in EagleBridge::WeexCoreHandler::PostTaskToMsgLoop

message_loop() in PostTaskToMsgLoop() could be nullptr if InitFramework() 
is not invoked.

* Avoid multiple initialization.

* Revert changes of InitSciptThread

* Post successCallback in RequestHandler to JSThread.

* Revert "Post successCallback in RequestHandler to JSThread."

This reverts commit 04bc4068

* Delete `;`
---
 weex_core/Source/android/wrap/wx_bridge.cpp | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/weex_core/Source/android/wrap/wx_bridge.cpp 
b/weex_core/Source/android/wrap/wx_bridge.cpp
index e73bc12..53ec056 100755
--- a/weex_core/Source/android/wrap/wx_bridge.cpp
+++ b/weex_core/Source/android/wrap/wx_bridge.cpp
@@ -39,7 +39,6 @@
 #include "base/android/jni_type.h"
 #include "base/android/jni/jbytearray_ref.h"
 #include "base/android/jniprebuild/jniheader/WXBridge_jni.h"
-#include "base/log_defines.h"
 #include "core/config/core_environment.h"
 #include "core/layout/layout.h"
 #include "core/layout/measure_func_adapter_impl_android.h"
@@ -305,7 +304,9 @@ static void SetDeviceDisplay(JNIEnv* env, jobject jcaller, 
jstring instanceId,
 
 static jint InitFramework(JNIEnv* env, jobject object, jstring script,
   jobject params) {
-  WXBridge::Instance()->Reset(env, object);
+  if (!WXBridge::Instance()->jni_object()) {
+WXBridge::Instance()->Reset(env, object);
+  }
   // Init platform thread --- ScriptThread
   WeexCoreManager::Instance()->InitScriptThread();
   // Exception handler for so
@@ -620,6 +621,9 @@ static jint CreateInstanceContext(JNIEnv* env, jobject 
jcaller,
 
   // If strategy is DATA_RENDER_BINARY, jscript is a jbyteArray, otherwise 
jstring
   // TODO use better way
+  if (!WXBridge::Instance()->jni_object()) {
+WXBridge::Instance()->Reset(env, jcaller);
+  }
   if (scoped_render_strategy.getChars() != nullptr
   && strcmp(scoped_render_strategy.getChars(), "DATA_RENDER_BINARY") == 0) 
{
 JByteArrayRef byte_array(env, static_cast(jscript.Get()));



[GitHub] [incubator-weex] lucky-chen merged pull request #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
lucky-chen merged pull request #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
52ff6689457515ee1c731d8ffe362a648b163353
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-weex] branch master updated (a994ce9 -> 5df2e4e)

2019-08-14 Thread moshen
This is an automated email from the ASF dual-hosted git repository.

moshen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git.


from a994ce9  [Android] record ipc exception history and weexCoreThread 
stackTrace when white screen or js process died/reload (#2826)
 new 86bc455  [iOS] output render timeline on iOS
 new 36f47c9  Merge branch 'master' into master
 new 5df2e4e  Merge pull request #2822 from jianhan-he/master

The 11710 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ios/sdk/WeexSDK.xcodeproj/project.pbxproj  | 12 +--
 ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m   | 11 +--
 ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h  |  2 +
 ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm |  8 ++
 .../WeexSDK/Sources/Manager/WXComponentManager.mm  |  4 +-
 ios/sdk/WeexSDK/Sources/Model/WXComponent.mm   |  5 +-
 .../Sources/Model/WXSDKInstance_performance.m  |  4 +-
 ...{WXConsoleLogModule.m => WXConsoleLogModule.mm} |  6 ++
 .../WeexSDK/Sources/Performance/WXApmForInstance.h |  5 ++
 .../WeexSDK/Sources/Performance/WXApmForInstance.m | 97 ++
 .../core/bridge/platform/core_side_in_platform.cpp |  8 ++
 .../core/bridge/platform/core_side_in_platform.h   |  1 +
 weex_core/Source/core/bridge/platform_bridge.h |  2 +
 .../core/network/ios/default_request_handler.mm|  8 ++
 14 files changed, 156 insertions(+), 17 deletions(-)
 rename ios/sdk/WeexSDK/Sources/Module/{WXConsoleLogModule.m => 
WXConsoleLogModule.mm} (88%)



[GitHub] [incubator-weex] wqyfavor merged pull request #2822: [iOS] output render timeline on iOS

2019-08-14 Thread GitBox
wqyfavor merged pull request #2822: [iOS] output render timeline on iOS
URL: https://github.com/apache/incubator-weex/pull/2822
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
4bf1e4e14f0e2b0c78b73d5762fb977eab30ae69
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
0f86d81187d54b456c2decf2189c34fd6d893dca
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
6122f55d7de05a06593ed1a4b2d32d151d33a7c2
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
0ff50f7fa539556849b27c37d677e1e059880b27
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
04bc4068fe798b3a7eb5501897b7f14547a475ef
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2822: [iOS] output render timeline on iOS

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2822: [iOS] output render timeline on iOS
URL: https://github.com/apache/incubator-weex/pull/2822#issuecomment-521121598
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
36f47c94456b22281a79155d1f2499c16f78cee6
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
174029f742a978992100a55fc5d11ae6c2eea7bd
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
weex-bot commented on issue #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
 :warning:
 If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
ac42ac7c16144c9427e1c8148a7013c2313d6c46
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] YorkShen opened a new pull request #2827: [Android] Fix Android JNI Crash

2019-08-14 Thread GitBox
YorkShen opened a new pull request #2827: [Android] Fix Android JNI Crash
URL: https://github.com/apache/incubator-weex/pull/2827
 
 
   `jni_object()` in `ReportException()` could be nullptr if `InitFramework()` 
is not invoked.
   
   ```
   JNI DETECTED ERROR IN APPLICATION: obj == null
in call to CallVoidMethodV
   from int 
com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(java.lang.String, 
java.lang.String, java.lang.String, com.taobao.weex.bridge.WXJSObject[])
   ..
   
   (_JNIEnv::CallVoidMethod(_jobject*, _jmethodID*, ...)+22)
   (WeexCore::WXBridge::ReportException(_JNIEnv*, char const*, char const*, 
char const*)+132)
(WeexCore::AndroidSide::ReportException(char const*, char const*, char 
const*)+34)
   ..
   
   (WeexCore::CoreSideInPlatform::CreateInstance(char const*, char const*, char 
const*, int, char const*, char const*, char const*, 
std::__ndk1::vector>&, char const*)+820)
   at com.taobao.weex.bridge.WXBridge.nativeCreateInstanceContext(Native method)
   at com.taobao.weex.bridge.WXBridge.createInstanceContext(Taobao:233)
   at 
com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstanceContext(Taobao:1981)
   at com.taobao.weex.bridge.WXBridgeManager.invokeCreateInstance(Taobao:1709)
   ```
   
   
   
   
   
   
   # Brief Description of the PR
   
   # Checklist
   * Demo:
   * Documentation:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-weex] branch master updated: [Android] record ipc exception history and weexCoreThread stackTrace when white screen or js process died/reload (#2826)

2019-08-14 Thread dongyayun
This is an automated email from the ASF dual-hosted git repository.

dongyayun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
 new a994ce9  [Android] record ipc exception history and weexCoreThread 
stackTrace when white screen or js process died/reload (#2826)
a994ce9 is described below

commit a994ce97e72535032dccf9007471f7f890765356
Author: chen 
AuthorDate: Wed Aug 14 18:10:50 2019 +0800

[Android] record ipc exception history and weexCoreThread stackTrace when 
white screen or js process died/reload (#2826)
---
 .../main/java/com/taobao/weex/WXSDKInstance.java   |  1 +
 .../com/taobao/weex/bridge/WXBridgeManager.java| 39 ++
 .../com/taobao/weex/performance/WXStateRecord.java | 21 +---
 .../java/com/taobao/weex/utils/WXLogUtils.java |  4 +++
 .../bridge/script/script_side_in_multi_process.cpp | 36 ++--
 .../android/multiprocess/weex_js_connection.cpp|  2 +-
 .../Source/third_party/IPC/IPCFutexPageQueue.cpp   |  1 +
 7 files changed, 67 insertions(+), 37 deletions(-)

diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java 
b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
index a774e88..23d4089 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
@@ -944,6 +944,7 @@ public class WXSDKInstance implements 
IWXActivityStateListener,View.OnLayoutChan
 Map args = new HashMap<>(1);
 String vieTreeMsg = WhiteScreenUtils.takeViewTreeSnapShot(this);
 args.put("viewTree",null == vieTreeMsg?"null viewTreeMsg":vieTreeMsg);
+
args.put("weexCoreThreadStackTrace",WXBridgeManager.getInstance().getWeexCoreThreadStackTrace());
 
 for (Map.Entry entry: 
WXStateRecord.getInstance().getStateInfo().entrySet()){
   args.put(entry.getKey(),entry.getValue());
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java 
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index d363651..145730c 100755
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -884,6 +884,10 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
 url = instance.getBundleUrl();
 instance.setHasException(true);
   }
+  Map extInfo = new HashMap<>(2);
+  
extInfo.put("weexCoreThreadStackTrace:",WXBridgeManager.getInstance().getWeexCoreThreadStackTrace());
+  
extInfo.put("wxStateInfo",WXStateRecord.getInstance().getStateInfo().toString());
+
   if(!isCrashFileEmpty) {
 try {
 if (WXEnvironment.getApplication() != null) {
@@ -894,15 +898,15 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
   WXLogUtils.e(WXLogUtils.getStackTrace(e));
 }
 WXStateRecord.getInstance().onJSCCrash();
-callReportCrash(crashFile, instanceId, url);
+callReportCrash(crashFile, instanceId, url,extInfo);
   } else {
 WXStateRecord.getInstance().onJSEngineReload();
- commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, 
WXErrorCode.WX_ERR_RELOAD_PAGE, "reboot jsc Engine", instanceId, url);
+ commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, 
WXErrorCode.WX_ERR_RELOAD_PAGE, "reboot jsc Engine", instanceId, url,extInfo);
   }
 
   if (reInitCount > CRASHREINIT) {
 WXExceptionUtils.commitCriticalExceptionRT("jsEngine", 
WXErrorCode.WX_ERR_RELOAD_PAGE_EXCEED_LIMIT,
-"callReportCrashReloadPage","reInitCount:"+reInitCount,null);
+"callReportCrashReloadPage","reInitCount:"+reInitCount,extInfo);
 return IWXBridge.INSTANCE_RENDERING_ERROR;
   }
   reInitCount++;
@@ -974,7 +978,7 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
 return false;
   }
 
-  public void callReportCrash(String crashFile, final String instanceId, final 
String url) {
+  public void callReportCrash(String crashFile, final String instanceId, final 
String url,final Map extInfo) {
 // statistic weex core process crash
 Date date = new Date();
 DateFormat format = new SimpleDateFormat("MMddHHmmss", Locale.US);
@@ -1005,7 +1009,7 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
   // }
   result.append(s + "\n");
 }
-commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, 
WXErrorCode.WX_ERR_JSC_CRASH, result.toString(), instanceId, url);
+commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, 
WXErrorCode.WX_ERR_JSC_CRASH, result.toString(), instanceId, url,extInfo);
 br.close();
   } catch (Exception e) {
 

[GitHub] [incubator-weex] Darin726 merged pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
Darin726 merged pull request #2826: [Android] record ipc exception history and 
weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2826: [Android] record ipc exception 
history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
3dee67ed4f8e7c10aedec18c8bd49973ac05715e
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot removed a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
weex-bot removed a comment on issue #2826: [Android] record ipc exception 
history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521158796
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 AndroidLint Result
   
 
   
 :no_entry_sign:
 
   
 
   
 
   Implied default locale in case 
conversion
 
 
   
   
   ../../src/main/java/com/taobao/weex/bridge/WXBridgeManager.java:3614:
 Implicitly using the default locale is a common source 
of bugs: Use String.format(Locale, ...) instead
3611 
3612   try {
3613 
stringBuilder.append(String.format("Thread Name: 
'%s'\n", mJSThread.getName()));
3614 
stringBuilder.append(String.format("\"%s\" prio=%d tid=%d %s\n", mJSThread.getName(), 
mJSThread.getPriority(), mJSThread.getId(), 
mJSThread.getState()));
3615 
3616 for 
(StackTraceElement e: mJSThread.getStackTrace()){
3617   
stringBuilder.append(String.format("\tat %s\n", 
e.toString()));
   
   
   
   
   Calling String#toLowerCase() or #toUpperCase() 
without specifying an explicit locale is a common source of bugs. The 
reason for that is that those methods will use the current locale on the user's 
device, and even though the code appears to work correctly when you are 
developing the app, it will fail in some locales. For example, in the Turkish 
locale, the uppercase replacement for i is not 
I.
   
   If you want the methods to just perform ASCII replacement, for example to 
convert an enum name, call String#toUpperCase(Locale.US) instead. 
If you really want to use the current locale, call 
String#toUpperCase(Locale.getDefault()) instead.More info: http://developer.android.com/reference/java/util/Locale.html#default_locale;>http://developer.android.com/reference/java/util/Locale.html#default_locale
   To suppress this error, use the issue id "DefaultLocale" as explained 
in the Suppressing Warnings and Errors section.
   
   
   
   
   
   DefaultLocale
   
   
   Correctness
   
   
   Warning
   
   
   Priority 6/10
   
   
 
 
   
   Explain
   Dismiss
   
 
 
   
 
   
   
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-weex] branch master updated: [Android] Android] restart weexCoreThread when reload JSEngine because thread maybe in lock state and can't execute reload action (block) (#2824)

2019-08-14 Thread dongyayun
This is an automated email from the ASF dual-hosted git repository.

dongyayun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
 new c72e6b5  [Android] Android] restart weexCoreThread when reload 
JSEngine because thread maybe in lock state and can't execute reload action 
(block) (#2824)
c72e6b5 is described below

commit c72e6b5a833f66ed048042d1e4fb385aa61ed97c
Author: chen 
AuthorDate: Wed Aug 14 17:06:00 2019 +0800

[Android] Android] restart weexCoreThread when reload JSEngine because 
thread maybe in lock state and can't execute reload action (block) (#2824)
---
 .../java/com/taobao/weex/bridge/WXBridgeManager.java  | 19 +++
 1 file changed, 19 insertions(+)

diff --git 
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java 
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index aca5ac2..d363651 100755
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -867,6 +867,14 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
 
   }
 
+  public void restartWeexCoreThread(){
+  WXLogUtils.e("weex","restartWeexCoreThread");
+  WXThread oldThread = mJSThread;
+  mJSThread = new WXThread("WeexJSBridgeThread", this);
+  mJSHandler = mJSThread.getHandler();
+  oldThread.quit();
+  }
+
   public int callReportCrashReloadPage(String instanceId, String crashFile) {
 boolean isCrashFileEmpty = TextUtils.isEmpty(crashFile);
 try {
@@ -914,6 +922,17 @@ public class WXBridgeManager implements Callback, 
BactchExecutor {
   if (WXSDKManager.getInstance().getSDKInstance(instanceId) != null) {
 boolean reloadThisInstance = shouldReloadCurrentInstance(
 
WXSDKManager.getInstance().getSDKInstance(instanceId).getBundleUrl());
+boolean restartCoreThread = true;
+IWXConfigAdapter adapter = 
WXSDKManager.getInstance().getWxConfigAdapter();
+if (null != adapter){
+String config = 
adapter.getConfig("wxapm","restartCoreThread","true");
+restartCoreThread = Boolean.valueOf(config);
+}
+if (restartCoreThread){
+  WXBridgeManager.getInstance().restartWeexCoreThread();
+}
+
WXSDKManager.getInstance().getSDKInstance(instanceId).getContainerInfo()
+.put("restartWeexCoreThread",String.valueOf(restartCoreThread));
 new ActionReloadPage(instanceId, reloadThisInstance).executeAction();
   }
 



[GitHub] [incubator-weex] Darin726 merged pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
Darin726 merged pull request #2824: [Android] Android] restart weexCoreThread 
when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
weex-bot edited a comment on issue #2826: [Android] record ipc exception 
history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
47650b60125868fb2ccad1f294fcd433908e7fa1
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
lucky-chen commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313768858
 
 

 ##
 File path: weex_core/Source/third_party/IPC/IPCFutexPageQueue.cpp
 ##
 @@ -112,6 +112,7 @@ void IPCFutexPageQueue::lock(size_t id, bool checkFinish)
 break;
 }
 struct timespec waitTime = { m_timeoutSec, 0 };
+LOGE("IPCException IPCFutexPageQueue:: start futex wait");
 
 Review comment:
   fix done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
lucky-chen commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313768901
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -876,6 +876,10 @@ public int callReportCrashReloadPage(String instanceId, 
String crashFile) {
 url = instance.getBundleUrl();
 instance.setHasException(true);
   }
+  Map extInfo = new HashMap<>(1);
 
 Review comment:
   fix done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
lucky-chen commented on a change in pull request #2824: [Android] Android] 
restart weexCoreThread when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824#discussion_r313767477
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -867,6 +867,14 @@ public int callRefreshFinish(String instanceId, String 
callback) {
 
   }
 
+  public void restartWeexCoreThread(){
+  WXLogUtils.e("weex","restartWeexCoreThread");
+  WXThread oldThread = mJSThread;
+  mJSThread = new WXThread("WeexJSBridgeThread", this);
+  mJSHandler = mJSThread.getHandler();
+  oldThread.quit();
 
 Review comment:
   1. HanderThread quit是比较安全的,remove 消息队列里面的所有消息,然后thread没有消息,loop结束,线程自然回收
   2. 灰度同步进行


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
lucky-chen commented on a change in pull request #2824: [Android] Android] 
restart weexCoreThread when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824#discussion_r313767326
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -867,6 +867,14 @@ public int callRefreshFinish(String instanceId, String 
callback) {
 
   }
 
+  public void restartWeexCoreThread(){
+  WXLogUtils.e("weex","restartWeexCoreThread");
+  WXThread oldThread = mJSThread;
+  mJSThread = new WXThread("WeexJSBridgeThread", this);
+  mJSHandler = mJSThread.getHandler();
+  oldThread.quit();
 
 Review comment:
   1. HanderThread quit是比较安全的,remove 消息队列里面的所有消息,然后thread没有消息,loop结束,线程自然回收
   2. 灰度同步进行


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
lucky-chen commented on a change in pull request #2824: [Android] Android] 
restart weexCoreThread when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824#discussion_r313767326
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -867,6 +867,14 @@ public int callRefreshFinish(String instanceId, String 
callback) {
 
   }
 
+  public void restartWeexCoreThread(){
+  WXLogUtils.e("weex","restartWeexCoreThread");
+  WXThread oldThread = mJSThread;
+  mJSThread = new WXThread("WeexJSBridgeThread", this);
+  mJSHandler = mJSThread.getHandler();
+  oldThread.quit();
 
 Review comment:
   1. HanderThread quit是比较安全的,remove 消息队列里面的所有消息,然后thread没有消息,loop结束,线程自然回收
   2. 灰度同步进行


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
weex-bot commented on issue #2826: [Android] record ipc exception history and 
weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521158796
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 AndroidLint Result
   
 
   
 :no_entry_sign:
 
   
 
   
 
   Implied default locale in case 
conversion
 
 
   
   
   ../../src/main/java/com/taobao/weex/bridge/WXBridgeManager.java:3614:
 Implicitly using the default locale is a common source 
of bugs: Use String.format(Locale, ...) instead
3611 
3612   try {
3613 
stringBuilder.append(String.format("Thread Name: 
'%s'\n", mJSThread.getName()));
3614 
stringBuilder.append(String.format("\"%s\" prio=%d tid=%d %s\n", mJSThread.getName(), 
mJSThread.getPriority(), mJSThread.getId(), 
mJSThread.getState()));
3615 
3616 for 
(StackTraceElement e: mJSThread.getStackTrace()){
3617   
stringBuilder.append(String.format("\tat %s\n", 
e.toString()));
   
   
   
   
   Calling String#toLowerCase() or #toUpperCase() 
without specifying an explicit locale is a common source of bugs. The 
reason for that is that those methods will use the current locale on the user's 
device, and even though the code appears to work correctly when you are 
developing the app, it will fail in some locales. For example, in the Turkish 
locale, the uppercase replacement for i is not 
I.
   
   If you want the methods to just perform ASCII replacement, for example to 
convert an enum name, call String#toUpperCase(Locale.US) instead. 
If you really want to use the current locale, call 
String#toUpperCase(Locale.getDefault()) instead.More info: http://developer.android.com/reference/java/util/Locale.html#default_locale;>http://developer.android.com/reference/java/util/Locale.html#default_locale
   To suppress this error, use the issue id "DefaultLocale" as explained 
in the Suppressing Warnings and Errors section.
   
   
   
   
   
   DefaultLocale
   
   
   Correctness
   
   
   Warning
   
   
   Priority 6/10
   
   
 
 
   
   Explain
   Dismiss
   
 
 
   
 
   
   
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] zsmjhtn commented on issue #2755: [Android]errorCode = -1001, WXBridgeManager.mInit is dangerous

2019-08-14 Thread GitBox
zsmjhtn commented on issue #2755: [Android]errorCode =  -1001,  
WXBridgeManager.mInit is dangerous
URL: https://github.com/apache/incubator-weex/issues/2755#issuecomment-521158668
 
 
   I have met the same error,waiting for the reply,but no reply any more


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] Darin726 commented on a change in pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
Darin726 commented on a change in pull request #2824: [Android] Android] 
restart weexCoreThread when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824#discussion_r313764346
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -867,6 +867,14 @@ public int callRefreshFinish(String instanceId, String 
callback) {
 
   }
 
+  public void restartWeexCoreThread(){
+  WXLogUtils.e("weex","restartWeexCoreThread");
+  WXThread oldThread = mJSThread;
+  mJSThread = new WXThread("WeexJSBridgeThread", this);
+  mJSHandler = mJSThread.getHandler();
+  oldThread.quit();
 
 Review comment:
   程序还在运行, 直接 quit 有风险吗? 有发过灰度吗


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] Darin726 commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
Darin726 commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313766158
 
 

 ##
 File path: weex_core/Source/third_party/IPC/IPCFutexPageQueue.cpp
 ##
 @@ -112,6 +112,7 @@ void IPCFutexPageQueue::lock(size_t id, bool checkFinish)
 break;
 }
 struct timespec waitTime = { m_timeoutSec, 0 };
+LOGE("IPCException IPCFutexPageQueue:: start futex wait");
 
 Review comment:
   IPC_LOGE


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] Darin726 commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
Darin726 commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313765655
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -876,6 +876,10 @@ public int callReportCrashReloadPage(String instanceId, 
String crashFile) {
 url = instance.getBundleUrl();
 instance.setHasException(true);
   }
+  Map extInfo = new HashMap<>(1);
 
 Review comment:
   map 的 size 为啥不直接设置成 2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
weex-bot commented on issue #2826: [Android] record ipc exception history and 
weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen opened a new pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox
lucky-chen opened a new pull request #2826: [Android] record ipc exception 
history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826
 
 
   [Android] record ipc exception history and weexCoreThread stackTrace when 
white screen or js process died/reload


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
weex-bot commented on issue #2824: [Android] Android] restart weexCoreThread 
when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824#issuecomment-521148273
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
a72e7530145f362f12e522eab1427dbb88ecc508
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen closed pull request #2825: Feature/ws record thread ipc info

2019-08-14 Thread GitBox
lucky-chen closed pull request #2825: Feature/ws record thread ipc info
URL: https://github.com/apache/incubator-weex/pull/2825
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen opened a new pull request #2825: Feature/ws record thread ipc info

2019-08-14 Thread GitBox
lucky-chen opened a new pull request #2825: Feature/ws record thread ipc info
URL: https://github.com/apache/incubator-weex/pull/2825
 
 
[Android] Android] restart weexCoreThread when reload JSEngine because 
thread maybe in lock state and can't execute reload action (block)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] lucky-chen opened a new pull request #2824: [Android] Android] restart weexCoreThread when reload JSEngine becaus…

2019-08-14 Thread GitBox
lucky-chen opened a new pull request #2824: [Android] Android] restart 
weexCoreThread when reload JSEngine becaus…
URL: https://github.com/apache/incubator-weex/pull/2824
 
 
[Android] Android] restart weexCoreThread when reload JSEngine because 
thread maybe in lock state and can't execute reload action (block)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] EthanYangHIT opened a new issue #2823: input 组件 设置 disabled 属性 导致 value 被置空

2019-08-14 Thread GitBox
EthanYangHIT opened a new issue #2823: input 组件 设置 disabled 属性 导致 value 被置空
URL: https://github.com/apache/incubator-weex/issues/2823
 
 
   复现 demo 
   http://dotwe.org/vue/5ac72625aa381c630d2ec67ff229a918


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] weex-bot commented on issue #2822: [iOS] output render timeline on iOS

2019-08-14 Thread GitBox
weex-bot commented on issue #2822: [iOS] output render timeline on iOS
URL: https://github.com/apache/incubator-weex/pull/2822#issuecomment-521121598
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
86bc455a5186609d8fe886dbdcb3e22add5c1d6f
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] jianhan-he opened a new pull request #2822: [iOS] output render timeline on iOS

2019-08-14 Thread GitBox
jianhan-he opened a new pull request #2822: [iOS] output render timeline on iOS
URL: https://github.com/apache/incubator-weex/pull/2822
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-weex] jianhan-he closed pull request #2818: [iOS] output render timeline on iOS

2019-08-14 Thread GitBox
jianhan-he closed pull request #2818: [iOS] output render timeline on iOS
URL: https://github.com/apache/incubator-weex/pull/2818
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services