[GitHub] incubator-weex pull request #1301: [WEEX-485][Android] fix slider bug: scrol...

[luckybilly]

Github user luckybilly closed the pull request at:

https://github.com/apache/incubator-weex/pull/1301


---

[GitHub] incubator-weex issue #1301: [WEEX-485][Android] fix slider bug: scroll when ...

[luckybilly]

Github user luckybilly commented on the issue:

https://github.com/apache/incubator-weex/pull/1301
  
PR has been merged, but the status is not updated... Is it a github bug?


---

[GitHub] incubator-weex pull request #1302: [WEEX-487][Android] bug fix: scrollable="...

[luckybilly]

Github user luckybilly closed the pull request at:

https://github.com/apache/incubator-weex/pull/1302


---

[GitHub] incubator-weex issue #1302: [WEEX-487][Android] bug fix: scrollable="false" ...

[luckybilly]

Github user luckybilly commented on the issue:

https://github.com/apache/incubator-weex/pull/1302
  
PR has been merged, but the status is not updated... Is it a github bug?


---

[GitHub] incubator-weex pull request #1302: [WEEX-487][Android] bug fix: scrollable="...

[luckybilly]

GitHub user luckybilly opened a pull request:

https://github.com/apache/incubator-weex/pull/1302

[WEEX-487][Android] bug fix: scrollable="false" not work on android

[WEEX-487][Android] bug fix: scrollable="false" not work on android

issue: [[WEEX-487]](https://issues.apache.org/jira/browse/WEEX-487)

remove `mAdapter.getRealCount() > 0` from [WXSlider.setScrollable(boolean 
scrollable)](https://github.com/apache/incubator-weex/blob/master/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java#L403:10)
```java
  @WXComponentProp(name = Constants.Name.SCROLLABLE)
  public void setScrollable(boolean scrollable) {
if (mViewPager != null && mAdapter != null) {
  if(mAdapter.getRealCount() > 0){ //remove this line, because there is 
no data when init slider
mViewPager.setScrollable(scrollable);
  }
}
  }
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/luckybilly/incubator-weex 
fix-slider-scrollable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1302


commit c64bda5c3f20c38b5d9eea8497a2b475fdddb394
Author: qiyi 
Date:   2018-06-29T03:48:39Z

[WEEX-487][Android] bug fix: scrollable="false" not work on android




---

[GitHub] incubator-weex pull request #1301: [WEEX-485][Android] fix slider bug: scrol...

[luckybilly]

GitHub user luckybilly opened a pull request:

https://github.com/apache/incubator-weex/pull/1301

[WEEX-485][Android] fix slider bug: scroll when scrollable=false make…

[WEEX-485][Android] fix slider bug: scroll when scrollable=false make index 
not work

issue: [[WEEX-485]](https://issues.apache.org/jira/browse/WEEX-485)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/luckybilly/incubator-weex fix_slider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1301


commit e9b1641e2ee4d486df21e527020ba702b211c78d
Author: qiyi 
Date:   2018-06-29T03:23:25Z

[WEEX-485][Android] fix slider bug: scroll when scrollable=false make index 
not work




---

[GitHub] incubator-weex pull request #1122: [android] fix wrong parameter for WXBridg...

[luckybilly]

GitHub user luckybilly opened a pull request:

https://github.com/apache/incubator-weex/pull/1122

[android] fix wrong parameter for WXBridgeManager.invokeRegisterModules

fix bug: use `mRegisterComponentFailList` in 
`WXBridgeManager.registerModules` method by mistake:

https://user-images.githubusercontent.com/4155835/39044554-182d1400-44c3-11e8-9c3a-7a6e7a1b1f8b.png;>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/luckybilly/incubator-weex fix-wrong-parameter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1122


commit 5f7370ec8c00645436312a04ff58deb8f9ef7398
Author: qiyi <qiyi@...>
Date:   2018-04-20T09:36:06Z

[android] fix wrong parameter for WXBridgeManager.invokeRegisterModules




---