[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox 
lucky-chen commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313768858
 
 

 ##
 File path: weex_core/Source/third_party/IPC/IPCFutexPageQueue.cpp
 ##
 @@ -112,6 +112,7 @@ void IPCFutexPageQueue::lock(size_t id, bool checkFinish)
 break;
 }
 struct timespec waitTime = { m_timeoutSec, 0 };
+LOGE("IPCException IPCFutexPageQueue:: start futex wait");
 
 Review comment:
   fix done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox 
lucky-chen commented on a change in pull request #2826: [Android] record ipc 
exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#discussion_r313768901
 
 

 ##
 File path: 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##
 @@ -876,6 +876,10 @@ public int callReportCrashReloadPage(String instanceId, 
String crashFile) {
 url = instance.getBundleUrl();
 instance.setHasException(true);
   }
+  Map extInfo = new HashMap<>(1);
 
 Review comment:
   fix done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services