[GitHub] [incubator-weex] weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …
weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace … URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 3dee67ed4f8e7c10aedec18c8bd49973ac05715e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …
weex-bot edited a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace … URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: Current pr not bind the milestone :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js";>dangerJS against 47650b60125868fb2ccad1f294fcd433908e7fa1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services