[GitHub] [incubator-weex] weex-bot commented on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox 
weex-bot commented on issue #2826: [Android] record ipc exception history and 
weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521158796
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 AndroidLint Result
   
 
   
 :no_entry_sign:
 
   
 
   
 
   Implied default locale in case 
conversion
 
 
   
   
   ../../src/main/java/com/taobao/weex/bridge/WXBridgeManager.java:3614:
 Implicitly using the default locale is a common source 
of bugs: Use String.format(Locale, ...) instead
3611 
3612   try {
3613 
stringBuilder.append(String.format("Thread Name: 
'%s'\n", mJSThread.getName()));
3614 
stringBuilder.append(String.format("\"%s\" prio=%d tid=%d %s\n", mJSThread.getName(), 
mJSThread.getPriority(), mJSThread.getId(), 
mJSThread.getState()));
3615 
3616 for 
(StackTraceElement e: mJSThread.getStackTrace()){
3617   
stringBuilder.append(String.format("\tat %s\n", 
e.toString()));
   
   
   
   
   Calling String#toLowerCase() or #toUpperCase() 
without specifying an explicit locale is a common source of bugs. The 
reason for that is that those methods will use the current locale on the user's 
device, and even though the code appears to work correctly when you are 
developing the app, it will fail in some locales. For example, in the Turkish 
locale, the uppercase replacement for i is not 
I.
   
   If you want the methods to just perform ASCII replacement, for example to 
convert an enum name, call String#toUpperCase(Locale.US) instead. 
If you really want to use the current locale, call 
String#toUpperCase(Locale.getDefault()) instead.More info: http://developer.android.com/reference/java/util/Locale.html#default_locale;>http://developer.android.com/reference/java/util/Locale.html#default_locale
   To suppress this error, use the issue id "DefaultLocale" as explained 
in the Suppressing Warnings and Errors section.
   
   
   
   
   
   DefaultLocale
   
   
   Correctness
   
   
   Warning
   
   
   Priority 6/10
   
   
 
 
   
   Explain
   Dismiss
   
 
 
   
 
   
   
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-weex] weex-bot commented on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

2019-08-14 Thread GitBox 
weex-bot commented on issue #2826: [Android] record ipc exception history and 
weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521154402
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 No Changelog changes! - Can you add a Changelog? To do 
so,append your changes to the changelog.md
   
 
   
 :warning:
 Current pr not bind the milestone
   
 
   
 :warning:
 If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: http://dotwe.org/vue
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 
d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services