[GitHub] incubator-weex pull request #853: [WEEX-105][iOS] bug-fix about setting nan ...

2017-11-16 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/853


---

[GitHub] incubator-weex pull request #853: [WEEX-105][iOS] bug-fix about setting nan ...

2017-11-12 Thread acton393 
GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/853

[WEEX-105][iOS] bug-fix about setting nan frame crash

try to protect nan crash when set frame containing nan value.
Last Exception Backtrace:
0   CoreFoundation  0x0001830301c0 
__exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib 0x000181a6855c 
_objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation  0x000183030108 +[NSException 
raise:format:] :116 (in CoreFoundation)
3   QuartzCore  0x000186335db8 
CA::Layer::set_position(CA::Vec2 const&, bool) :152 (in QuartzCore)
4   QuartzCore  0x000186335f2c -[CALayer 
setPosition:] :40 (in QuartzCore)
5   QuartzCore  0x0001863364c4 -[CALayer setFrame:] 
:448 (in QuartzCore)
6   UIKit   0x000188e71e2c -[UIView(Geometry) 
setFrame:] :784 (in UIKit)
7   Taobao4iPhone   0x000102d6ad4c 
_43-[WXComponent(Layout) _frameDidCalculated:]_block_invoke 
WXComponent+Layout.m:136

Last Exception Backtrace 2:
0   CoreFoundation  0x000185b12fe0 
__exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib 0x000184574538 
_objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation  0x000185b12f28 +[NSException 
raise:format:] :116 (in CoreFoundation)
3   QuartzCore  0x000188e29798 
CA::Layer::set_bounds(CA::Rect const&, bool) :204 (in QuartzCore)
4   QuartzCore  0x000188e299e0 -[CALayer 
setBounds:] :100 (in QuartzCore)
5   UIKit   0x00018bc908c8 -[UIView(Geometry) 
setBounds:] :404 (in UIKit)
6   UIKit   0x00018bc9eacc -[UIScrollView 
setBounds:] :988 (in UIKit)
7   UIKit   0x00018bd271c8 -[UITableView 
setBounds:] :224 (in UIKit)
8   UIKit   0x00018bc62828 -[UIScrollView 
setContentOffset:] :400 (in UIKit)
9   UIKit   0x00018bd191dc -[UITableView 
setContentOffset:] :272 (in UIKit)
10  Taobao4iPhone   0x000102d7b6e8 -[WXTableView 
setContentOffset:] WXListComponent.m:63 (in Taobao4iPhone)
11  UIKit   0x00018bde6d08 -[UIScrollView 
_updatePanGesture] :1988 (in UIKit)
12  UIKit   0x00018c2168d0 
-[UIGestureRecognizerTarget _sendActionWithGestureRecognizer:] :64 (in UIKit)
13  UIKit   0x00018c21a104 
_UIGestureRecognizerSendTargetActions :124 (in UIKit)
14  UIKit   0x00018bdd40b4 
_UIGestureRecognizerSendActions :252 (in UIKit)

Bug: 105


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
bug-fix-setframe-nan-crash

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #853


commit 784fd75d324c2034a362a79251a87c295eb9fbea
Author: acton393 
Date:   2017-11-13T07:08:15Z

[WEEX-105][iOS] bug-fix about setting nan frame crash

try to protect nan crash when set frame containing nan value.
Last Exception Backtrace:
0   CoreFoundation  0x0001830301c0 
__exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib 0x000181a6855c 
_objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation  0x000183030108 +[NSException 
raise:format:] :116 (in CoreFoundation)
3   QuartzCore  0x000186335db8 
CA::Layer::set_position(CA::Vec2 const&, bool) :152 (in QuartzCore)
4   QuartzCore  0x000186335f2c -[CALayer 
setPosition:] :40 (in QuartzCore)
5   QuartzCore  0x0001863364c4 -[CALayer setFrame:] 
:448 (in QuartzCore)
6   UIKit   0x000188e71e2c -[UIView(Geometry) 
setFrame:] :784 (in UIKit)
7   Taobao4iPhone   0x000102d6ad4c 
_43-[WXComponent(Layout) _frameDidCalculated:]_block_invoke 
WXComponent+Layout.m:136

Last Exception Backtrace 2:
0   CoreFoundation  0x000185b12fe0 
__exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib 0x000184574538 
_objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation  0x000185b12f28 +[NSException 
raise:format:] :116 (in CoreFoundation)
3   QuartzCore  0x000188e29798