martin-g commented on PR #812:
URL: https://github.com/apache/wicket/pull/812#issuecomment-2025892576
Just edit the adoc files. Maven does the rest.
One more thing - please update wicket.xsd too
On Thu, 28 Mar 2024 at 20:06, Ernesto Reinaldo Barreiro <
***@***.***> wrote:
reiern70 commented on PR #812:
URL: https://github.com/apache/wicket/pull/812#issuecomment-2025817087
> It would be nice to update the guide too.
Do we have any documentation on how to update the guide?
--
This is an automated message from the Apache Git Service.
To respond to the
reiern70 commented on code in PR #812:
URL: https://github.com/apache/wicket/pull/812#discussion_r1543387516
##
wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java:
##
@@ -157,7 +158,7 @@ protected final void onEvent(final
martin-g commented on code in PR #812:
URL: https://github.com/apache/wicket/pull/812#discussion_r1540068379
##
wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java:
##
@@ -1558,9 +1566,9 @@ public final IValidatable newValidatable()
*
reiern70 merged PR #812:
URL: https://github.com/apache/wicket/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reiern70 commented on PR #812:
URL: https://github.com/apache/wicket/pull/812#issuecomment-2018153079
> Maybe another possibility is to add an application setting toggling this
behavior (and set it to disabled by default). This, way existing applications
will not break.
Added some
reiern70 commented on PR #812:
URL: https://github.com/apache/wicket/pull/812#issuecomment-2009573146
Maybe another possibility is to add an application setting toggling this
behavior (and set it to disabled by default). This, way existing applications
will not break.
--
This is an
reiern70 commented on code in PR #812:
URL: https://github.com/apache/wicket/pull/812#discussion_r1531440581
##
wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java:
##
@@ -301,6 +302,13 @@ private String getLabel()
}
}
+
reiern70 commented on code in PR #812:
URL: https://github.com/apache/wicket/pull/812#discussion_r1531439695
##
wicket-core/src/test/java/org/apache/wicket/markup/html/form/AutoLabelTest.java:
##
@@ -163,22 +167,80 @@ class MyTestPage2 extends TestPage
}
+ //
reiern70 opened a new pull request, #812:
URL: https://github.com/apache/wicket/pull/812
The label associated with form component should always be rendered when the
form component is rendered via AJAX. This way we ensure the state of the label
is consistent with form component's state.
10 matches
Mail list logo
