git commit: WICKET-4768: remove unneeded whitespace in TabbedPanel
Updated Branches: refs/heads/master 1ac055336 - 492034e3a WICKET-4768: remove unneeded whitespace in TabbedPanel Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/492034e3 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/492034e3 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/492034e3 Branch: refs/heads/master Commit: 492034e3a919de5fbb27f02b6ede851b95417e87 Parents: 1ac0553 Author: Emond Papegaaij papega...@apache.org Authored: Sat Sep 22 16:58:37 2012 +0200 Committer: Emond Papegaaij papega...@apache.org Committed: Sat Sep 22 16:58:37 2012 +0200 -- .../extensions/markup/html/tabs/TabbedPanel.html |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/492034e3/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.html -- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.html b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.html index 0f3ebe0..23cbe2b 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.html +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.html @@ -18,9 +18,7 @@ wicket:panel xmlns:wicket=http://wicket.apache.org; div wicket:id=tabs-container class=tab-row ul - li wicket:id=tabs - a href=# wicket:id=linkspan wicket:id=title[[tab title]]/span/a - /li + li wicket:id=tabsa href=# wicket:id=linkspan wicket:id=title[[tab title]]/span/a/li /ul /div div wicket:id=panel class=tab-panel!-- no panel --/div
[jira] [Assigned] (WICKET-4768) Whitespace in TabbedPanel markup causes layout issues
[ https://issues.apache.org/jira/browse/WICKET-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij reassigned WICKET-4768: --- Assignee: Emond Papegaaij Whitespace in TabbedPanel markup causes layout issues - Key: WICKET-4768 URL: https://issues.apache.org/jira/browse/WICKET-4768 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.8, 6.0.0 Reporter: Michael Lemke Assignee: Emond Papegaaij Labels: css, html, template Fix For: 6.1.0 Attachments: TabbedPanel.html The markup for TabbedPanel contains too much whitespace. This causes issues as outlined e.g. in http://stackoverflow.com/questions/241512/best-way-to-manage-whitespace-between-inline-list-items Could the markup be modified as given in the answers on Stackoverflow? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4768) Whitespace in TabbedPanel markup causes layout issues
[ https://issues.apache.org/jira/browse/WICKET-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij resolved WICKET-4768. - Resolution: Fixed The whitespace inside the li is removed, as suggested. Whitespace in TabbedPanel markup causes layout issues - Key: WICKET-4768 URL: https://issues.apache.org/jira/browse/WICKET-4768 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.8, 6.0.0 Reporter: Michael Lemke Assignee: Emond Papegaaij Labels: css, html, template Fix For: 6.1.0 Attachments: TabbedPanel.html The markup for TabbedPanel contains too much whitespace. This causes issues as outlined e.g. in http://stackoverflow.com/questions/241512/best-way-to-manage-whitespace-between-inline-list-items Could the markup be modified as given in the answers on Stackoverflow? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4773) ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij reassigned WICKET-4773: --- Assignee: Emond Papegaaij ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER --- Key: WICKET-4773 URL: https://issues.apache.org/jira/browse/WICKET-4773 Project: Wicket Issue Type: Bug Affects Versions: 6.0.0 Reporter: Dan Haywood Assignee: Emond Papegaaij Fix For: 6.1.0 Test case created on github, see https://github.com/danhaywood/wicket-4773 browse to http://localhost:8080/wicket-examples/forminput and follow the instructions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4773: do not clear reporter until the message is rendered
Updated Branches:
refs/heads/master 492034e3a - bf8a9576c
WICKET-4773: do not clear reporter until the message is rendered
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bf8a9576
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bf8a9576
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bf8a9576
Branch: refs/heads/master
Commit: bf8a9576c3414a1f497ac71f1a56be1f0f31a7ea
Parents: 492034e
Author: Emond Papegaaij papega...@apache.org
Authored: Sat Sep 22 19:59:57 2012 +0200
Committer: Emond Papegaaij papega...@apache.org
Committed: Sat Sep 22 19:59:57 2012 +0200
--
.../apache/wicket/feedback/FeedbackMessage.java|5 -
1 files changed, 4 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/bf8a9576/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
index bf5047b..b52f4e9 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
@@ -267,6 +267,9 @@ public class FeedbackMessage implements IDetachable
@Override
public void detach()
{
- reporter = null;
+ if (rendered)
+ {
+ reporter = null;
+ }
}
}
[jira] [Resolved] (WICKET-4773) ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij resolved WICKET-4773. - Resolution: Fixed The code that clears the reporter was added long ago for WICKET-2384 to prevent a memory leak. I'm not sure if this is still needed, but it seems better to at least not clear reporter until the message is rendered. ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER --- Key: WICKET-4773 URL: https://issues.apache.org/jira/browse/WICKET-4773 Project: Wicket Issue Type: Bug Affects Versions: 6.0.0 Reporter: Dan Haywood Assignee: Emond Papegaaij Fix For: 6.1.0 Test case created on github, see https://github.com/danhaywood/wicket-4773 browse to http://localhost:8080/wicket-examples/forminput and follow the instructions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
