[jira] [Created] (WICKET-5235) Button silently ignores MissingResourceException

2013-06-14 Thread Markus Pulkkinen (JIRA)
Markus Pulkkinen created WICKET-5235:


 Summary: Button silently ignores MissingResourceException
 Key: WICKET-5235
 URL: https://issues.apache.org/jira/browse/WICKET-5235
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.8.0
Reporter: Markus Pulkkinen
Priority: Minor


When a Button is rendered with model that tries to load a resource that is 
missing
and ResourceSettings.throwExceptionOnMissingResource = true, the button catches 
and silently ignores the MissingResourceException in onComponentTag(), which is 
not nice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5231) ModalWindow is not vertically draggable

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683167#comment-13683167
 ] 

Martin Grigorov commented on WICKET-5231:
-

Hi,

At http://www.wicket-library.com/wicket-examples/ajax/modal-window?2 you may 
try with 1.5.10.
I just tried with Google Chrome 27 and Firefox 21 and both work OK.

Do you reproduce the issue there ?

 ModalWindow is not vertically draggable
 ---

 Key: WICKET-5231
 URL: https://issues.apache.org/jira/browse/WICKET-5231
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.4
 Environment: RHEL Linux
Reporter: Brian Detweiler
Priority: Minor

 iFrame ModalWindows are draggable horizontally along the x-Axis, but not 
 vertically along the y-Axis. If there are any tests I can do to help out with 
 this bug, let me know. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5235) Button silently ignores MissingResourceException

2013-06-14 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683174#comment-13683174
 ] 

Sven Meier commented on WICKET-5235:


Digging into the old SF svn it seems that the try-catch was introduced first 
[1] to make it possible to use a button inside a CompoundPropertyModel. Later 
on this case was handled additionally by overriding #initModel().

So it seems to me, that the try-catch is obsolete.

[1] 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java?r1=457657r2=457679diff_format=h
[2] 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java?r1=459746r2=459762diff_format=h

 Button silently ignores MissingResourceException
 

 Key: WICKET-5235
 URL: https://issues.apache.org/jira/browse/WICKET-5235
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.8.0
Reporter: Markus Pulkkinen
Priority: Minor

 When a Button is rendered with model that tries to load a resource that is 
 missing
 and ResourceSettings.throwExceptionOnMissingResource = true, the button 
 catches and silently ignores the MissingResourceException in 
 onComponentTag(), which is not nice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-4904) Use a behavior that modifies AbstractLink's markup when disabled

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683180#comment-13683180
 ] 

Martin Grigorov commented on WICKET-4904:
-

About 'href' attribute - the link says that it should be OK. If there are any 
problems with older browsers then we can use javascript:void(0) as a value. I 
have seen it working in older IE versions.

About DisabledLinkBehavior - the markup for a disabled link in Wicket 6.x is: 
spanemspan. Currently Wicket 7 produces just emspan.  

public DisabledLinkBehavior()
{
this(spanem, /em/span);
}

will make it as before.

 Use a behavior that modifies AbstractLink's markup when disabled
 

 Key: WICKET-4904
 URL: https://issues.apache.org/jira/browse/WICKET-4904
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.3.0
Reporter: Martin Grigorov
Assignee: Sven Meier
Priority: Minor
 Fix For: 7.0.0

 Attachments: WICKET-4904.patch


 Currently Wicket transforms a tag to spanem when a link is disabled.
 Recently Wicket-Bootstrap user filed issue 
 https://github.com/l0rdn1kk0n/wicket-bootstrap/issues/79 that this breaks the 
 UI because Twitter Bootstrap needs just 'disabled=disabled' attribute in 
 a.
 With the new strategy it will be possible to set global strategy and override 
 it per link.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5234 OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/master d8789519d - 4b37aaf88


WICKET-5234 OnEventHeaderItem can't be applied via AJAX

Transform OnEventHeaderItem to appendJavaScript, as OnLoadHeaderItem and 
OnDomReadyHeaderItem


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4b37aaf8
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4b37aaf8
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4b37aaf8

Branch: refs/heads/master
Commit: 4b37aaf883baccd2e0153b92f21490b8fe4b2dbe
Parents: d878951
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 11:13:04 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 11:13:04 2013 +0300

--
 .../java/org/apache/wicket/ajax/AbstractAjaxResponse.java   | 9 +
 1 file changed, 9 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/4b37aaf8/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
index a183ef4..b660edc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
@@ -29,6 +29,7 @@ import org.apache.wicket.Page;
 import org.apache.wicket.markup.head.HeaderItem;
 import org.apache.wicket.markup.head.IHeaderResponse;
 import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
+import org.apache.wicket.markup.head.OnEventHeaderItem;
 import org.apache.wicket.markup.head.OnLoadHeaderItem;
 import org.apache.wicket.markup.head.internal.HeaderResponse;
 import org.apache.wicket.markup.html.internal.HtmlHeaderContainer;
@@ -534,6 +535,14 @@ public abstract class AbstractAjaxResponse
markItemRendered(item);
}
}
+   else if (item instanceof OnEventHeaderItem)
+   {
+   if (!wasItemRendered(item))
+   {
+   
AbstractAjaxResponse.this.appendJavaScript(((OnEventHeaderItem) 
item).getJavaScript());
+   markItemRendered(item);
+   }
+   }
else if (item instanceof OnDomReadyHeaderItem)
{
if (!wasItemRendered(item))



[jira] [Commented] (WICKET-5234) OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683187#comment-13683187
 ] 

Martin Grigorov commented on WICKET-5234:
-

The suggested patch is not good because the prepended/appended scripts by 
AjaxRequestTarget may need JS library to be able to do their job.



 OnEventHeaderItem can't be applied via AJAX
 ---

 Key: WICKET-5234
 URL: https://issues.apache.org/jira/browse/WICKET-5234
 Project: Wicket
  Issue Type: Bug
Reporter: Andrea Del Bene
 Attachments: OnEventAjax.zip, WICKET-5234.patch


 OnEventHeaderItem doesn't have effect if it is applied to a component 
 refreshed via AJAX. In short, OnEventHeaderItem is applied before the 
 component is refreshed via AJAX, hence the releated event handler is removed 
 from the target component. 
 We could modify JavaScript function Wicket.Ajax.Call.loadedCallback in order 
 to apply header contributors after the component has been refreshed (see 
 patch).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[1/2] git commit: WICKET-5234 OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/wicket-6.x 323db880e - 2468536a3


WICKET-5234 OnEventHeaderItem can't be applied via AJAX

Transform OnEventHeaderItem to appendJavaScript, as OnLoadHeaderItem and 
OnDomReadyHeaderItem


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2468536a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2468536a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2468536a

Branch: refs/heads/wicket-6.x
Commit: 2468536a3896c07c7e436d7c4f191d776935c845
Parents: 6ccd27c
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 11:13:04 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 11:14:29 2013 +0300

--
 .../java/org/apache/wicket/ajax/AbstractAjaxResponse.java   | 9 +
 1 file changed, 9 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/2468536a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
index a183ef4..b660edc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
@@ -29,6 +29,7 @@ import org.apache.wicket.Page;
 import org.apache.wicket.markup.head.HeaderItem;
 import org.apache.wicket.markup.head.IHeaderResponse;
 import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
+import org.apache.wicket.markup.head.OnEventHeaderItem;
 import org.apache.wicket.markup.head.OnLoadHeaderItem;
 import org.apache.wicket.markup.head.internal.HeaderResponse;
 import org.apache.wicket.markup.html.internal.HtmlHeaderContainer;
@@ -534,6 +535,14 @@ public abstract class AbstractAjaxResponse
markItemRendered(item);
}
}
+   else if (item instanceof OnEventHeaderItem)
+   {
+   if (!wasItemRendered(item))
+   {
+   
AbstractAjaxResponse.this.appendJavaScript(((OnEventHeaderItem) 
item).getJavaScript());
+   markItemRendered(item);
+   }
+   }
else if (item instanceof OnDomReadyHeaderItem)
{
if (!wasItemRendered(item))



[2/2] git commit: WICKET-5233 Component.getBehaviors() can be implemented slightly more efficiently

2013-06-14 Thread mgrigorov
WICKET-5233 Component.getBehaviors() can be implemented slightly more 
efficiently


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6ccd27ca
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6ccd27ca
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6ccd27ca

Branch: refs/heads/wicket-6.x
Commit: 6ccd27caf22ca63fc37a14f71690e9017c57d07f
Parents: 323db88
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Jun 13 14:56:14 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 11:14:29 2013 +0300

--
 wicket-core/src/main/java/org/apache/wicket/Component.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/6ccd27ca/wicket-core/src/main/java/org/apache/wicket/Component.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java 
b/wicket-core/src/main/java/org/apache/wicket/Component.java
index 24332c4..8fa63a3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Component.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
@@ -4521,7 +4521,7 @@ public abstract class Component
 */
public final List? extends Behavior getBehaviors()
{
-   return getBehaviors(Behavior.class);
+   return getBehaviors(null);
}
 
 }



[jira] [Resolved] (WICKET-5234) OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5234.
-

   Resolution: Fixed
Fix Version/s: 7.0.0
   6.9.0
 Assignee: Martin Grigorov

AjaxHeaderResponse now handles OnEventHeaderItem specially as it already does 
with OnLoad and OnDomReady header items

 OnEventHeaderItem can't be applied via AJAX
 ---

 Key: WICKET-5234
 URL: https://issues.apache.org/jira/browse/WICKET-5234
 Project: Wicket
  Issue Type: Bug
Reporter: Andrea Del Bene
Assignee: Martin Grigorov
 Fix For: 6.9.0, 7.0.0

 Attachments: OnEventAjax.zip, WICKET-5234.patch


 OnEventHeaderItem doesn't have effect if it is applied to a component 
 refreshed via AJAX. In short, OnEventHeaderItem is applied before the 
 component is refreshed via AJAX, hence the releated event handler is removed 
 from the target component. 
 We could modify JavaScript function Wicket.Ajax.Call.loadedCallback in order 
 to apply header contributors after the component has been refreshed (see 
 patch).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5234 OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/wicket-1.5.x 1ece22c16 - 9f86fcffd


WICKET-5234 OnEventHeaderItem can't be applied via AJAX


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9f86fcff
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9f86fcff
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9f86fcff

Branch: refs/heads/wicket-1.5.x
Commit: 9f86fcffdbea516bb5f78b9e622f595a2c85d99c
Parents: 1ece22c
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 11:27:48 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 11:27:48 2013 +0300

--
 .../java/org/apache/wicket/ajax/AjaxRequestTarget.java | 13 +
 1 file changed, 13 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/9f86fcff/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
index 22e5146..6aabf18 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
@@ -1163,6 +1163,19 @@ public class AjaxRequestTarget implements 
IPageRequestHandler, ILoggableRequestH
}
}
 
+
+   @Override
+   public void renderOnEventJavaScript(String target, String 
event, String javascript)
+   {
+   ListString token = Arrays.asList(javascript-event, 
window, event, javascript);
+   if (wasRendered(token) == false)
+   {
+   // execute the javascript after all other 
scripts are executed
+   appendJavaScripts.add(javascript);
+   markRendered(token);
+   }
+   }
+
/**
 * 
 * @see 
org.apache.wicket.markup.html.internal.HeaderResponse#getRealResponse()



[jira] [Updated] (WICKET-5234) OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov updated WICKET-5234:


Fix Version/s: 1.5.11

 OnEventHeaderItem can't be applied via AJAX
 ---

 Key: WICKET-5234
 URL: https://issues.apache.org/jira/browse/WICKET-5234
 Project: Wicket
  Issue Type: Bug
Reporter: Andrea Del Bene
Assignee: Martin Grigorov
 Fix For: 6.9.0, 7.0.0, 1.5.11

 Attachments: OnEventAjax.zip, WICKET-5234.patch


 OnEventHeaderItem doesn't have effect if it is applied to a component 
 refreshed via AJAX. In short, OnEventHeaderItem is applied before the 
 component is refreshed via AJAX, hence the releated event handler is removed 
 from the target component. 
 We could modify JavaScript function Wicket.Ajax.Call.loadedCallback in order 
 to apply header contributors after the component has been refreshed (see 
 patch).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5234 OnEventHeaderItem can't be applied via AJAX

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/wicket-1.5.x 9f86fcffd - 6a8123def


WICKET-5234 OnEventHeaderItem can't be applied via AJAX


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6a8123de
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6a8123de
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6a8123de

Branch: refs/heads/wicket-1.5.x
Commit: 6a8123def69361571cccf34a4ed6db132dc4c9e9
Parents: 9f86fcf
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 11:31:41 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 11:31:41 2013 +0300

--
 .../java/org/apache/wicket/ajax/AjaxRequestTarget.java   | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/6a8123de/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
index 6aabf18..f6904f9 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
@@ -1171,7 +1171,16 @@ public class AjaxRequestTarget implements 
IPageRequestHandler, ILoggableRequestH
if (wasRendered(token) == false)
{
// execute the javascript after all other 
scripts are executed
-   appendJavaScripts.add(javascript);
+   String script = new StringBuilder()
+   .append(Wicket.Event.add()
+   .append(target)
+   .append(, \)
+   .append(event)
+   .append(\, function(event) { 
)
+   .append(javascript)
+   .append(;});)
+   .toString();
+   appendJavaScripts.add(script);
markRendered(token);
}
}



[jira] [Commented] (WICKET-4904) Use a behavior that modifies AbstractLink's markup when disabled

2013-06-14 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683208#comment-13683208
 ] 

Sven Meier commented on WICKET-4904:


I don't think so: In Wicket 6.x a disabled link was rendered spanem - 
span was the modified component tag and em was explicitly written before 
the body.

 Use a behavior that modifies AbstractLink's markup when disabled
 

 Key: WICKET-4904
 URL: https://issues.apache.org/jira/browse/WICKET-4904
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.3.0
Reporter: Martin Grigorov
Assignee: Sven Meier
Priority: Minor
 Fix For: 7.0.0

 Attachments: WICKET-4904.patch


 Currently Wicket transforms a tag to spanem when a link is disabled.
 Recently Wicket-Bootstrap user filed issue 
 https://github.com/l0rdn1kk0n/wicket-bootstrap/issues/79 that this breaks the 
 UI because Twitter Bootstrap needs just 'disabled=disabled' attribute in 
 a.
 With the new strategy it will be possible to set global strategy and override 
 it per link.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-4904) Use a behavior that modifies AbstractLink's markup when disabled

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683211#comment-13683211
 ] 

Martin Grigorov commented on WICKET-4904:
-

You are correct.

 Use a behavior that modifies AbstractLink's markup when disabled
 

 Key: WICKET-4904
 URL: https://issues.apache.org/jira/browse/WICKET-4904
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.3.0
Reporter: Martin Grigorov
Assignee: Sven Meier
Priority: Minor
 Fix For: 7.0.0

 Attachments: WICKET-4904.patch


 Currently Wicket transforms a tag to spanem when a link is disabled.
 Recently Wicket-Bootstrap user filed issue 
 https://github.com/l0rdn1kk0n/wicket-bootstrap/issues/79 that this breaks the 
 UI because Twitter Bootstrap needs just 'disabled=disabled' attribute in 
 a.
 With the new strategy it will be possible to set global strategy and override 
 it per link.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5229) use jquery focusin/focusout for ajax focus tracking

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683237#comment-13683237
 ] 

Martin Grigorov commented on WICKET-5229:
-

The new code binds on 'window' element, i.e. uses event delegation.
The code in 6.x binds directly on input, select, textarea, button and 'a' 
elements.

I think the new code will break if attributes.setEventPropagation(STOP) is used 
somewhere in the hierarchy. 

 use jquery focusin/focusout for ajax focus tracking
 ---

 Key: WICKET-5229
 URL: https://issues.apache.org/jira/browse/WICKET-5229
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 7.0.0
Reporter: Sven Meier
Assignee: Sven Meier
 Fix For: 7.0.0


 Focus tracking in wicket-ajax-jquery.js can be simplified with jQuery 
 bubbling focusin/focusout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5229) use jquery focusin/focusout for ajax focus tracking

2013-06-14 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683259#comment-13683259
 ] 

Sven Meier commented on WICKET-5229:


For that to happen the developer would have to listen for focusin event and 
explicitely use EventPropagation#STOP in AjaxRequestAttributes. How likely is 
that? If we see a problem here, then we could never utilize event bubbling.

 use jquery focusin/focusout for ajax focus tracking
 ---

 Key: WICKET-5229
 URL: https://issues.apache.org/jira/browse/WICKET-5229
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 7.0.0
Reporter: Sven Meier
Assignee: Sven Meier
 Fix For: 7.0.0


 Focus tracking in wicket-ajax-jquery.js can be simplified with jQuery 
 bubbling focusin/focusout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5229) use jquery focusin/focusout for ajax focus tracking

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683267#comment-13683267
 ] 

Martin Grigorov commented on WICKET-5229:
-

Focus tracking in wicket-ajax.js is used internally by Wicket.
For example Wicket.Ajax.Call.success() calls 
window.setTimeout(Wicket.Focus.requestFocus();, 0); to refocus the last 
focused element if it has been replaced in the Ajax response.

I'm not sure how serious is this change. I just note that the change in the 
behavior is big enough to appear in someone's use case.

 use jquery focusin/focusout for ajax focus tracking
 ---

 Key: WICKET-5229
 URL: https://issues.apache.org/jira/browse/WICKET-5229
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 7.0.0
Reporter: Sven Meier
Assignee: Sven Meier
 Fix For: 7.0.0


 Focus tracking in wicket-ajax-jquery.js can be simplified with jQuery 
 bubbling focusin/focusout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


buildbot success in ASF Buildbot on wicket-master

2013-06-14 Thread buildbot
The Buildbot has detected a restored build on builder wicket-master while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/wicket-master/builds/1296

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: forced: by IRC user martin-g on channel ##wicket: None
Build Source Stamp: HEAD
Blamelist: 

Build succeeded!

sincerely,
 -The Buildbot





[jira] [Commented] (WICKET-5071) 404 Error on Nested ModalWindows in IE7 and IE8

2013-06-14 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683272#comment-13683272
 ] 

Martin Grigorov commented on WICKET-5071:
-

I'm able to reproduce it now. Let me see...

 404 Error on Nested ModalWindows in IE7 and IE8
 ---

 Key: WICKET-5071
 URL: https://issues.apache.org/jira/browse/WICKET-5071
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.5.8, 6.6.0
 Environment: Internet Explorer 8.0.7601.17514
 Internet Explorer 7.0.5730.13
 Jetty 7 (multiple versions replicate the problem)
 Tomcat 6
Reporter: Jered Myers
Assignee: Martin Grigorov
 Attachments: fix-WICKET-5071.patch, NestedModals.zip


 When opening a ModalWindow inside a ModalWindow, the inner ModalWindow 
 generates a 404 error.  Both windows use a PageCreator for content.
 To replicate, you must use an actual IE 7 or IE 8 browser, as this does not 
 replicate using developer tools and setting the document and brower to IE 7.
 The problem can be seen at 
 http://www.wicket-library.com/wicket-examples/ajax/modal-window.  I will 
 attach a Quickstart as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


buildbot failure in ASF Buildbot on wicket-branch-6.x

2013-06-14 Thread buildbot
The Buildbot has detected a new failure on builder wicket-branch-6.x while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/wicket-branch-6.x/builds/52

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: forced: by IRC user martin-g on channel ##wicket: None
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: failed compile

sincerely,
 -The Buildbot





[jira] [Commented] (WICKET-5225) Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()

2013-06-14 Thread Mischa Neumann (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683277#comment-13683277
 ] 

Mischa Neumann commented on WICKET-5225:


after creating the quick start app, I noticed that you have to set  the 
RenderStrategy.REDIRECT_TO_RENDER in your 
org.apache.wicket.WicketApplication.init() to make the bug occur.


 Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()
 --

 Key: WICKET-5225
 URL: https://issues.apache.org/jira/browse/WICKET-5225
 Project: Wicket
  Issue Type: Bug
  Components: wicket-auth-roles
Affects Versions: 6.8.0
 Environment: any
Reporter: Mischa Neumann

 we have a page with
 - a login form A (org.apache.wicket.markup.html.form.StatelessFormT)
 - a standard form B inside a panel which is secured with 
 @AuthorizeAction(action = Action.RENDER...)
 our problem: the user must submit the login form twice.
 reason:
 - when the page is requested the first time, the page is stateless cause none 
 of the visible children are stateful.
 - when the user now submits the login form, the page claims to be stateful, 
 the stateful component is form B. 
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  now handles the page as expired and omits the submit
 possible buggy code: 
 - the visiblity of components is computed before rendering in 
 org.apache.wicket.Component.setRenderAllowed()
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  calls only org.apache.wicket.MarkupContainer.internalInitialize() on the 
 current page to give it a chance for computing its visibility, 
 Component.setRenderAllowed() is not called

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-5225) Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()

2013-06-14 Thread Mischa Neumann (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mischa Neumann updated WICKET-5225:
---

Attachment: wicket-bug-5225-quickstart.zip

 Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()
 --

 Key: WICKET-5225
 URL: https://issues.apache.org/jira/browse/WICKET-5225
 Project: Wicket
  Issue Type: Bug
  Components: wicket-auth-roles
Affects Versions: 6.8.0
 Environment: any
Reporter: Mischa Neumann
 Attachments: wicket-bug-5225-quickstart.zip


 we have a page with
 - a login form A (org.apache.wicket.markup.html.form.StatelessFormT)
 - a standard form B inside a panel which is secured with 
 @AuthorizeAction(action = Action.RENDER...)
 our problem: the user must submit the login form twice.
 reason:
 - when the page is requested the first time, the page is stateless cause none 
 of the visible children are stateful.
 - when the user now submits the login form, the page claims to be stateful, 
 the stateful component is form B. 
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  now handles the page as expired and omits the submit
 possible buggy code: 
 - the visiblity of components is computed before rendering in 
 org.apache.wicket.Component.setRenderAllowed()
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  calls only org.apache.wicket.MarkupContainer.internalInitialize() on the 
 current page to give it a chance for computing its visibility, 
 Component.setRenderAllowed() is not called

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5229) use jquery focusin/focusout for ajax focus tracking

2013-06-14 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683291#comment-13683291
 ] 

Sven Meier commented on WICKET-5229:


IMHO the old solution was due for an overhaul:

// re-attach the events to the new components (a bit blunt method...)
// This should be changed for IE See comments in wicket-event.js add 
(attachEvent/detachEvent)
// IE this will cause double events for everything.. (mostly because of 
the jQuery.proxy(element))
Wicket.Focus.attachFocusEvent();

Note that if a developer uses #stopImmediately from his focus event handler, 
this would break Wicket's focus tracking too.

 use jquery focusin/focusout for ajax focus tracking
 ---

 Key: WICKET-5229
 URL: https://issues.apache.org/jira/browse/WICKET-5229
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 7.0.0
Reporter: Sven Meier
Assignee: Sven Meier
 Fix For: 7.0.0


 Focus tracking in wicket-ajax-jquery.js can be simplified with jQuery 
 bubbling focusin/focusout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Comment Edited] (WICKET-5225) Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()

2013-06-14 Thread Mischa Neumann (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683277#comment-13683277
 ] 

Mischa Neumann edited comment on WICKET-5225 at 6/14/13 10:55 AM:
--

after creating the quick start app, I noticed that you have to set  the 
RenderStrategy.REDIRECT_TO_RENDER in your 
org.apache.wicket.WicketApplication.init() to make the bug occur.

you will find the file attached.

  was (Author: mischa.neum...@init.de):
after creating the quick start app, I noticed that you have to set  the 
RenderStrategy.REDIRECT_TO_RENDER in your 
org.apache.wicket.WicketApplication.init() to make the bug occur.

  
 Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()
 --

 Key: WICKET-5225
 URL: https://issues.apache.org/jira/browse/WICKET-5225
 Project: Wicket
  Issue Type: Bug
  Components: wicket-auth-roles
Affects Versions: 6.8.0
 Environment: any
Reporter: Mischa Neumann
 Attachments: wicket-bug-5225-quickstart.zip


 we have a page with
 - a login form A (org.apache.wicket.markup.html.form.StatelessFormT)
 - a standard form B inside a panel which is secured with 
 @AuthorizeAction(action = Action.RENDER...)
 our problem: the user must submit the login form twice.
 reason:
 - when the page is requested the first time, the page is stateless cause none 
 of the visible children are stateful.
 - when the user now submits the login form, the page claims to be stateful, 
 the stateful component is form B. 
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  now handles the page as expired and omits the submit
 possible buggy code: 
 - the visiblity of components is computed before rendering in 
 org.apache.wicket.Component.setRenderAllowed()
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  calls only org.apache.wicket.MarkupContainer.internalInitialize() on the 
 current page to give it a chance for computing its visibility, 
 Component.setRenderAllowed() is not called

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Comment Edited] (WICKET-5225) Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()

2013-06-14 Thread Mischa Neumann (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683277#comment-13683277
 ] 

Mischa Neumann edited comment on WICKET-5225 at 6/14/13 10:56 AM:
--

after creating the quick start app, I noticed that you have to set  the 
RenderStrategy.REDIRECT_TO_RENDER in your 
org.apache.wicket.WicketApplication.init() to make the bug occur.

you will find the file attached.

thank you too!

  was (Author: mischa.neum...@init.de):
after creating the quick start app, I noticed that you have to set  the 
RenderStrategy.REDIRECT_TO_RENDER in your 
org.apache.wicket.WicketApplication.init() to make the bug occur.

you will find the file attached.
  
 Inconsistent behaviour of org.apache.wicket.Page.isPageStateless()
 --

 Key: WICKET-5225
 URL: https://issues.apache.org/jira/browse/WICKET-5225
 Project: Wicket
  Issue Type: Bug
  Components: wicket-auth-roles
Affects Versions: 6.8.0
 Environment: any
Reporter: Mischa Neumann
 Attachments: wicket-bug-5225-quickstart.zip


 we have a page with
 - a login form A (org.apache.wicket.markup.html.form.StatelessFormT)
 - a standard form B inside a panel which is secured with 
 @AuthorizeAction(action = Action.RENDER...)
 our problem: the user must submit the login form twice.
 reason:
 - when the page is requested the first time, the page is stateless cause none 
 of the visible children are stateful.
 - when the user now submits the login form, the page claims to be stateful, 
 the stateful component is form B. 
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  now handles the page as expired and omits the submit
 possible buggy code: 
 - the visiblity of components is computed before rendering in 
 org.apache.wicket.Component.setRenderAllowed()
 - 
 org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(IRequestCycle)
  calls only org.apache.wicket.MarkupContainer.internalInitialize() on the 
 current page to give it a chance for computing its visibility, 
 Component.setRenderAllowed() is not called

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5071 404 Error on Nested ModalWindows in IE7 and IE8

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/master 4b37aaf88 - b5cb9887f


WICKET-5071 404 Error on Nested ModalWindows in IE7 and IE8

PageInstanceMapper now will match if the baseUrl is 'page?..' and the request 
url is 'page?...'
An explicit mount of a page at 'page' will have higher priority because it is 
added later in CompoundRequestMapper


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b5cb9887
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b5cb9887
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b5cb9887

Branch: refs/heads/master
Commit: b5cb9887fecad4815849eca22441521ee35669e1
Parents: 4b37aaf
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 16:33:17 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 16:33:17 2013 +0300

--
 .../core/request/mapper/PageInstanceMapper.java |  4 ++
 .../request/mapper/PageInstanceMapperTest.java  | 49 +++-
 .../ajax/markup/html/modal/ModalWindow.java |  7 +--
 .../ajax/markup/html/modal/res/modal.js |  6 +--
 4 files changed, 54 insertions(+), 12 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/b5cb9887/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
index 9f75813..3789a9f 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
@@ -185,6 +185,10 @@ public class PageInstanceMapper extends 
AbstractComponentMapper
{
matches = true;
}
+   else if (urlStartsWith(request.getClientUrl(), pageIdentifier) 
 urlStartsWith(url, pageIdentifier))
+   {
+   matches = true;
+   }
 
return matches;
}

http://git-wip-us.apache.org/repos/asf/wicket/blob/b5cb9887/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
index a112640..d1fa307 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
@@ -31,6 +31,7 @@ import org.apache.wicket.request.IRequestHandler;
 import org.apache.wicket.request.Request;
 import org.apache.wicket.request.Url;
 import org.apache.wicket.request.component.IRequestableComponent;
+import org.apache.wicket.request.component.IRequestablePage;
 import org.junit.Test;
 
 /**
@@ -211,7 +212,53 @@ public class PageInstanceMapperTest extends 
AbstractMapperTest
 
IRequestHandler handler = encoder.mapRequest(request);
 
-   ((IPageRequestHandler)handler).getPage();
+   IRequestablePage page = ((IPageRequestHandler) 
handler).getPage();
+   checkPage(page, 4);
+   }
+
+
+   @Test
+   public void decode10()
+   {
+   final Url url = Url.parse(page?4);
+
+   Request request = new Request()
+   {
+   @Override
+   public Url getUrl()
+   {
+   return url;
+   }
+
+   @Override
+   public Locale getLocale()
+   {
+   return null;
+   }
+
+   @Override
+   public Charset getCharset()
+   {
+   return Charset.forName(UTF-8);
+   }
+
+   @Override
+   public Url getClientUrl()
+   {
+   return Url.parse(page);
+   }
+
+   @Override
+   public Object getContainerRequest()
+   {
+   return null;
+   }
+   };
+
+   IRequestHandler handler = encoder.mapRequest(request);
+
+   IRequestablePage page = ((IPageRequestHandler) 
handler).getPage();
+   

[jira] [Resolved] (WICKET-5071) 404 Error on Nested ModalWindows in IE7 and IE8

2013-06-14 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5071.
-

   Resolution: Fixed
Fix Version/s: 7.0.0
   6.9.0

An additional check in PageInstanceMapper that matches on baseUrl 'page?...' 
and request url 'page?...' fixed this problem.
There is no need of ie8_url in modal window code.

 404 Error on Nested ModalWindows in IE7 and IE8
 ---

 Key: WICKET-5071
 URL: https://issues.apache.org/jira/browse/WICKET-5071
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.5.8, 6.6.0
 Environment: Internet Explorer 8.0.7601.17514
 Internet Explorer 7.0.5730.13
 Jetty 7 (multiple versions replicate the problem)
 Tomcat 6
Reporter: Jered Myers
Assignee: Martin Grigorov
 Fix For: 6.9.0, 7.0.0

 Attachments: fix-WICKET-5071.patch, NestedModals.zip


 When opening a ModalWindow inside a ModalWindow, the inner ModalWindow 
 generates a 404 error.  Both windows use a PageCreator for content.
 To replicate, you must use an actual IE 7 or IE 8 browser, as this does not 
 replicate using developer tools and setting the document and brower to IE 7.
 The problem can be seen at 
 http://www.wicket-library.com/wicket-examples/ajax/modal-window.  I will 
 attach a Quickstart as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5071 404 Error on Nested ModalWindows in IE7 and IE8

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/wicket-6.x 2468536a3 - 432310bda


WICKET-5071 404 Error on Nested ModalWindows in IE7 and IE8

PageInstanceMapper now will match if the baseUrl is 'page?..' and the request 
url is 'page?...'
An explicit mount of a page at 'page' will have higher priority because it is 
added later in CompoundRequestMapper


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/432310bd
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/432310bd
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/432310bd

Branch: refs/heads/wicket-6.x
Commit: 432310bdae50498419ff84031430d02ba36d346d
Parents: 2468536
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 16:33:17 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 16:35:09 2013 +0300

--
 .../core/request/mapper/PageInstanceMapper.java |  4 ++
 .../request/mapper/PageInstanceMapperTest.java  | 49 +++-
 .../ajax/markup/html/modal/ModalWindow.java |  7 +--
 .../ajax/markup/html/modal/res/modal.js |  6 +--
 4 files changed, 54 insertions(+), 12 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/432310bd/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
index 9f75813..3789a9f 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/PageInstanceMapper.java
@@ -185,6 +185,10 @@ public class PageInstanceMapper extends 
AbstractComponentMapper
{
matches = true;
}
+   else if (urlStartsWith(request.getClientUrl(), pageIdentifier) 
 urlStartsWith(url, pageIdentifier))
+   {
+   matches = true;
+   }
 
return matches;
}

http://git-wip-us.apache.org/repos/asf/wicket/blob/432310bd/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
index a112640..d1fa307 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/PageInstanceMapperTest.java
@@ -31,6 +31,7 @@ import org.apache.wicket.request.IRequestHandler;
 import org.apache.wicket.request.Request;
 import org.apache.wicket.request.Url;
 import org.apache.wicket.request.component.IRequestableComponent;
+import org.apache.wicket.request.component.IRequestablePage;
 import org.junit.Test;
 
 /**
@@ -211,7 +212,53 @@ public class PageInstanceMapperTest extends 
AbstractMapperTest
 
IRequestHandler handler = encoder.mapRequest(request);
 
-   ((IPageRequestHandler)handler).getPage();
+   IRequestablePage page = ((IPageRequestHandler) 
handler).getPage();
+   checkPage(page, 4);
+   }
+
+
+   @Test
+   public void decode10()
+   {
+   final Url url = Url.parse(page?4);
+
+   Request request = new Request()
+   {
+   @Override
+   public Url getUrl()
+   {
+   return url;
+   }
+
+   @Override
+   public Locale getLocale()
+   {
+   return null;
+   }
+
+   @Override
+   public Charset getCharset()
+   {
+   return Charset.forName(UTF-8);
+   }
+
+   @Override
+   public Url getClientUrl()
+   {
+   return Url.parse(page);
+   }
+
+   @Override
+   public Object getContainerRequest()
+   {
+   return null;
+   }
+   };
+
+   IRequestHandler handler = encoder.mapRequest(request);
+
+   IRequestablePage page = ((IPageRequestHandler) 
handler).getPage();
+ 

buildbot success in ASF Buildbot on wicket-branch-6.x

2013-06-14 Thread buildbot
The Buildbot has detected a restored build on builder wicket-branch-6.x while 
building wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-branch-6.x/builds/53

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch wicket-6.x] 432310bdae50498419ff84031430d02ba36d346d
Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org

Build succeeded!

sincerely,
 -The Buildbot





git commit: WICKET-5235 exception should not be silently ignored, workaround for button in compoundPropertyModel is not needed

2013-06-14 Thread svenmeier
Updated Branches:
  refs/heads/master b5cb9887f - 11ef03bd1


WICKET-5235 exception should not be silently ignored, workaround for
button in compoundPropertyModel is not needed

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/11ef03bd
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/11ef03bd
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/11ef03bd

Branch: refs/heads/master
Commit: 11ef03bd10bd41ca1041d4937d99d73a3038a323
Parents: b5cb988
Author: svenmeier s...@meiers.net
Authored: Fri Jun 14 15:51:43 2013 +0200
Committer: svenmeier s...@meiers.net
Committed: Fri Jun 14 15:51:43 2013 +0200

--
 .../apache/wicket/markup/html/form/Button.java  | 13 +++-
 .../wicket/markup/html/form/ButtonTest.java | 21 ++--
 2 files changed, 18 insertions(+), 16 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/11ef03bd/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java
index 99dbfe5..3815600 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java
@@ -193,17 +193,10 @@ public class Button extends FormComponentString 
implements IFormSubmittingComp
// Default handling for component tag
super.onComponentTag(tag);
 
-   try
+   String value = getDefaultModelObjectAsString();
+   if (value != null  !.equals(value))
{
-   String value = getDefaultModelObjectAsString();
-   if (value != null  !.equals(value))
-   {
-   tag.put(value, value);
-   }
-   }
-   catch (Exception e)
-   {
-   // ignore.
+   tag.put(value, value);
}
 
// If the subclass specified javascript, use that

http://git-wip-us.apache.org/repos/asf/wicket/blob/11ef03bd/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ButtonTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ButtonTest.java 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ButtonTest.java
index 106663f..1f448d8 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ButtonTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ButtonTest.java
@@ -20,6 +20,7 @@ import org.apache.wicket.MarkupContainer;
 import org.apache.wicket.WicketTestCase;
 import org.apache.wicket.markup.IMarkupResourceStreamProvider;
 import org.apache.wicket.markup.html.WebPage;
+import org.apache.wicket.model.CompoundPropertyModel;
 import org.apache.wicket.model.IModel;
 import org.apache.wicket.model.Model;
 import org.apache.wicket.util.resource.IResourceStream;
@@ -39,25 +40,33 @@ public class ButtonTest extends WicketTestCase
@Test
public void valueAttribute()
{
-   TestPage testPage = new TestPage();
String text = some text  another text;
-   testPage.buttonModel.setObject(text);
+   TestPage testPage = new TestPage(Model.of(text));
tester.startPage(testPage);

assertTrue(tester.getLastResponseAsString().contains(Strings.escapeMarkup(text)));
}
 
+   /**
+* WICKET-5235 button does not use an inherited model
+*/
+   @Test
+   public void buttonDoesNotInheritModel()
+   {
+   TestPage testPage = new TestPage(null);
+   tester.startPage(testPage);
+   }
+
/** */
public static class TestPage extends WebPage implements 
IMarkupResourceStreamProvider
{
private static final long serialVersionUID = 1L;
-   FormVoid form;
+   FormObject form;
Button button;
-   IModelString buttonModel = Model.of((String)null);
 
/** */
-   public TestPage()
+   public TestPage(IModelString buttonModel)
{
-   add(form = new FormVoid(form));
+   add(form = new FormObject(form, new 
CompoundPropertyModel(new Object(;
form.add(button = new Button(button, buttonModel));
}
 



[jira] [Resolved] (WICKET-5235) Button silently ignores MissingResourceException

2013-06-14 Thread Sven Meier (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sven Meier resolved WICKET-5235.


   Resolution: Fixed
Fix Version/s: 7.0.0
 Assignee: Sven Meier

I removed the try-catch, since the workaround for button in 
compoundPropertyModel is not needed

 Button silently ignores MissingResourceException
 

 Key: WICKET-5235
 URL: https://issues.apache.org/jira/browse/WICKET-5235
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.8.0
Reporter: Markus Pulkkinen
Assignee: Sven Meier
Priority: Minor
 Fix For: 7.0.0


 When a Button is rendered with model that tries to load a resource that is 
 missing
 and ResourceSettings.throwExceptionOnMissingResource = true, the button 
 catches and silently ignores the MissingResourceException in 
 onComponentTag(), which is not nice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: WICKET-5056 Page mount with an optional named parameter overtakes a mount with more specific path

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/master 11ef03bd1 - 56169634c


WICKET-5056 Page mount with an optional named parameter overtakes a mount with 
more specific path


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/56169634
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/56169634
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/56169634

Branch: refs/heads/master
Commit: 56169634c82a58b2dc5c071fb8f1e80a531eaf56
Parents: 11ef03b
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 16:56:29 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 16:57:00 2013 +0300

--
 .../core/request/mapper/MountedMapper.java  | 10 +++-
 .../core/request/mapper/MountedMapperTest.java  | 58 
 2 files changed, 67 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/56169634/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
index ae742d6..12f8985 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
@@ -495,7 +495,15 @@ public class MountedMapper extends 
AbstractBookmarkableMapper
{
if (urlStartsWith(request.getUrl(), mountSegments))
{
-   return mountSegments.length;
+   /* see WICKET-5056 - alter score with pathSegment type 
*/
+   int countOptional = 0;
+   int fixedSegments = 0;
+   for (MountPathSegment pathSegment : pathSegments)
+   {
+   fixedSegments += pathSegment.getFixedPartSize();
+   countOptional += 
pathSegment.getOptionalParameters();
+   }
+   return mountSegments.length - countOptional + 
fixedSegments;
}
else
{

http://git-wip-us.apache.org/repos/asf/wicket/blob/56169634/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
index 3815361..d8cccb5 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
@@ -28,6 +28,7 @@ import 
org.apache.wicket.core.request.handler.RenderPageRequestHandler;
 import org.apache.wicket.markup.html.link.ILinkListener;
 import org.apache.wicket.request.IRequestHandler;
 import org.apache.wicket.request.IRequestMapper;
+import org.apache.wicket.request.Request;
 import org.apache.wicket.request.Url;
 import org.apache.wicket.request.component.IRequestableComponent;
 import org.apache.wicket.request.component.IRequestablePage;
@@ -809,4 +810,61 @@ public class MountedMapperTest extends AbstractMapperTest
Url url = optionPlaceholderEncoder.mapHandler(handler);
assertEquals(some/path/p2/p3/i1/i2?a=bb=c, url.toString());
}
+
+   /* WICKET-5056 **/
+   @Test
+   public void optionalParameterGetsLowerScore_ThanExactOne() throws 
Exception
+   {
+   final Url url = Url.parse(all/sindex);
+   final MountedMapper exactMount = new 
MountedMapper(/all/sindex, MockPage.class);
+   final MountedMapper optionalParameter = new 
MountedMapper(/all/#{exp}, MockPage.class);
+   Request request = getRequest(url);
+   final int exactCompatScore = 
exactMount.getCompatibilityScore(request);
+   final int optCompatScore = 
optionalParameter.getCompatibilityScore(request);
+   assertTrue(exactCompatScore should have greater compatibility 
score than optional one +
+got exact =  + exactCompatScore +  and optional =  
+ optCompatScore,
+   exactCompatScore  optCompatScore);
+   }
+
+   @Test
+   public void exactMountGetsBetterScore_ThanParameterOne() throws 
Exception
+   {
+   final Url url = Url.parse(all/sindex);
+   final MountedMapper exactMount = new 
MountedMapper(/all/sindex, MockPage.class);
+

[jira] [Resolved] (WICKET-5056) Page mount with an optional named parameter overtakes a mount with more specific path

2013-06-14 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5056.
-

   Resolution: Fixed
Fix Version/s: 7.0.0
   6.9.0

Thank you, Cedric!
You change is applied.

 Page mount with an optional named parameter overtakes a mount with more 
 specific path
 -

 Key: WICKET-5056
 URL: https://issues.apache.org/jira/browse/WICKET-5056
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.6.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
 Fix For: 6.9.0, 7.0.0


 See the discussion in http://markmail.org/thread/sgpiku27ah2tmcim
 Having:
   mountPage(/all/sindex,Page1.class);
   mountPage(/all/#{exp}, Page2.class);
 Request to /all/sindex will be handled by Page2.
 Compatibility score for optional parameters should be lower than mandatory 
 parameters which should be lower than exact value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[CONF] Apache Wicket Migration to Wicket 7.0

2013-06-14 Thread confluence







Migration to Wicket 7.0
Page edited by Sven Meier


Comment:
WICKET-5235


 Changes (1)
 




...
The href and disabled attributes are still added/removed by AbstractLink as required. But no further mangling of markup is performed. org.apache.wicket.markup.html.link.DisabledLinkBehavior can be used to restore the pre-Wicket-7.x representation of disabled links with emspan/span/em (note that em and span swap their position though). If the old behavior is need it can be easily re-applied by using org.apache.wicket.markup.html.link.DisabledLinkBehavior.LinkInstantiationListener.  
h5. Button no longer silently ignores exceptions [WICKET-5235|https://issues.apache.org/jira/browse/WICKET-5235] ... when it renders its model into the value attribute.   
h3. Deprecated classes/methods/fields are removed [WICKET-5201|https://issues.apache.org/jira/browse/WICKET-5201]  
...


Full Content

Migrating to Wicket 7.0



Environment

Wicket 7.0 requires at least Java 7
Wicket 7.0 requires Servlet 3.0

The HTTP response is not flushed automatically when the request is started in asynchronous mode. WICKET-5152


API changes


org/apache/wicket/core/util/io/SerializableChecker is replaced with org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream WICKET-4817
org/apache/wicket/markup/html/border/BoxBorder is removed with no replacement WICKET-4966.
org.apache.wicket.Component#renderHead(HtmlHeaderContainer) is renamed to Component#internalRenderHead(HtmlHeaderContainer) WICKET-4964
org.apache.wicket.request.resource.ResourceReference#getDependencies() now returns a mutable ListHeaderItem WICKET-5124
org.apache.wicket.model.StringResourceModel constructor accepts IModelString for its default value WICKET-4972
org.apache.wicket.extensions.validation.validator.+Xyz+Validator#decorate() now works with IValidationError WICKET-5174
org.apache.wicket.ajax.attributes.AjaxRequestAttributes#setAllowDefault is renamed to #setPreventDefault WICKET-5197
org.apache.wicket.ajax.attributes.AjaxRequestAttributes#eventPropagation is now BUBBLE by default WICKET-5198
org.apache.wicket.ajax.form.AjaxFormValidatingBehavior doesn't use static methods anymore WICKET-5196
org.apache.wicket.ajax.AjaxRequestTarget.IListener#updateAjaxAttributes() is introduced WICKET-5212
org.apache.wicket.ISessionListener#onUnbound(String) is added WICKET-5213
(Base)WicketTester uses org.junit.Assert instead of junit.framework.Assert
org.apache.wicket.Component#setMetaData() value could be only a Serializable WICKET-5227


Behavior changes


org.apache.wicket.request.Url#getQueryString WICKET-4664
org.apache.wicket.request.http.WebResponse encodes the value of the "filename" in Content-Disposition header WICKET-4934
org.apache.wicket.markup.html.form.FormComponentLabel outputs "required", "disabled" and "error" classes when its form component is either required, disabled or invalid. WICKET-5177
org.apache.wicket.markup.html.panel.FeedbackPanel Do not set CSS class on the li  span element for a feedback message WICKET-4831
AjaxEventBehavior doesn't prevent the default behavior of the _javascript_ event WICKET-5197
Ajax behaviors let _javascript_ events bubble by default WICKET-5198
PackageTextTemplate loads its content lazily WICKET-4579
AbstractLink no longer alters its markup to render itself as disabled WICKET-4904
Button no longer silently ignores exceptions WICKET-5235


Deprecated classes/methods/fields are removed WICKET-5201


AbstractDefaultAjaxBehavior's #getSuccessHandler(), #getFailureHandler(), #getChannel() and #getPrecondition() are removed.
The old Tree component in wicket-extensions is removed.


Dependency updates


Environment

Wicket 7.0 requires at least Java 7

Wicket 7.0 requires Servlet 3.0

The HTTP response is not flushed automatically when the request is started in asynchronous mode. WICKET-5152
This is an improvement in Wicket 7.0 which should not affect any application migrating from Wicket 6.x. But if you use Servlet 3.0's AsyncContext in IResource in Wicket 7 then make sure that your code flushes the http response after completing the request.

API changes

org/apache/wicket/core/util/io/SerializableChecker is replaced with org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream WICKET-4817
CheckingObjectOutputStream accepts a list of org.apache.wicket.core.util.objects.checker.IObjectChecker objects which are used to check for different kind of problems during object serialization. Commit diff: d0441059e0

org/apache/wicket/markup/html/border/BoxBorder is removed with no replacement WICKET-4966.

git commit: WICKET-5056 Page mount with an optional named parameter overtakes a mount with more specific path

2013-06-14 Thread mgrigorov
Updated Branches:
  refs/heads/wicket-6.x 432310bda - 2d1680645


WICKET-5056 Page mount with an optional named parameter overtakes a mount with 
more specific path


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2d168064
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2d168064
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2d168064

Branch: refs/heads/wicket-6.x
Commit: 2d1680645de63336cf877051c4597961b723cb5c
Parents: 432310b
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri Jun 14 16:56:29 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri Jun 14 16:57:19 2013 +0300

--
 .../core/request/mapper/MountedMapper.java  | 10 +++-
 .../core/request/mapper/MountedMapperTest.java  | 58 
 2 files changed, 67 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/2d168064/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
index 17e9af3..ce0ae78 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java
@@ -525,7 +525,15 @@ public class MountedMapper extends 
AbstractBookmarkableMapper
{
if (urlStartsWith(request.getUrl(), mountSegments))
{
-   return mountSegments.length;
+   /* see WICKET-5056 - alter score with pathSegment type 
*/
+   int countOptional = 0;
+   int fixedSegments = 0;
+   for (MountPathSegment pathSegment : pathSegments)
+   {
+   fixedSegments += pathSegment.getFixedPartSize();
+   countOptional += 
pathSegment.getOptionalParameters();
+   }
+   return mountSegments.length - countOptional + 
fixedSegments;
}
else
{

http://git-wip-us.apache.org/repos/asf/wicket/blob/2d168064/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
index 3815361..d8cccb5 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
@@ -28,6 +28,7 @@ import 
org.apache.wicket.core.request.handler.RenderPageRequestHandler;
 import org.apache.wicket.markup.html.link.ILinkListener;
 import org.apache.wicket.request.IRequestHandler;
 import org.apache.wicket.request.IRequestMapper;
+import org.apache.wicket.request.Request;
 import org.apache.wicket.request.Url;
 import org.apache.wicket.request.component.IRequestableComponent;
 import org.apache.wicket.request.component.IRequestablePage;
@@ -809,4 +810,61 @@ public class MountedMapperTest extends AbstractMapperTest
Url url = optionPlaceholderEncoder.mapHandler(handler);
assertEquals(some/path/p2/p3/i1/i2?a=bb=c, url.toString());
}
+
+   /* WICKET-5056 **/
+   @Test
+   public void optionalParameterGetsLowerScore_ThanExactOne() throws 
Exception
+   {
+   final Url url = Url.parse(all/sindex);
+   final MountedMapper exactMount = new 
MountedMapper(/all/sindex, MockPage.class);
+   final MountedMapper optionalParameter = new 
MountedMapper(/all/#{exp}, MockPage.class);
+   Request request = getRequest(url);
+   final int exactCompatScore = 
exactMount.getCompatibilityScore(request);
+   final int optCompatScore = 
optionalParameter.getCompatibilityScore(request);
+   assertTrue(exactCompatScore should have greater compatibility 
score than optional one +
+got exact =  + exactCompatScore +  and optional =  
+ optCompatScore,
+   exactCompatScore  optCompatScore);
+   }
+
+   @Test
+   public void exactMountGetsBetterScore_ThanParameterOne() throws 
Exception
+   {
+   final Url url = Url.parse(all/sindex);
+   final MountedMapper exactMount = new 
MountedMapper(/all/sindex, MockPage.class);
+

[jira] [Commented] (WICKET-5231) ModalWindow is not vertically draggable

2013-06-14 Thread Brian Detweiler (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683608#comment-13683608
 ] 

Brian Detweiler commented on WICKET-5231:
-

It seems to work fine there. Perhaps there is something in our code that is 
causing the problem. Thanks for your input! You can close this.

 ModalWindow is not vertically draggable
 ---

 Key: WICKET-5231
 URL: https://issues.apache.org/jira/browse/WICKET-5231
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.4
 Environment: RHEL Linux
Reporter: Brian Detweiler
Priority: Minor

 iFrame ModalWindows are draggable horizontally along the x-Axis, but not 
 vertically along the y-Axis. If there are any tests I can do to help out with 
 this bug, let me know. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-5071) 404 Error on Nested ModalWindows in IE7 and IE8

2013-06-14 Thread Jered Myers (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683894#comment-13683894
 ] 

Jered Myers commented on WICKET-5071:
-

This still does not seem to be working.  I used the branch 
remotes/origin/wicket-6.x to build.  I ran this test in IE 8. Here is what is 
in my console:

SSL access to the quickstart has been enabled on port 8443
You can access the application using SSL on https://localhost:8443

 STARTING EMBEDDED JETTY SERVER, PRESS ANY KEY TO STOP
INFO  - Server - jetty-7.6.3.v20120416
INFO  - tandardDescriptorProcessor - NO JSP Support for /, did not find 
org.apache.jasper.servlet.JspServlet
INFO  - ContextHandler - started 
o.e.j.w.WebAppContext{/,file:/home/neville/workspace_wicket/NestedModals/src/main/webapp/},src/main/webapp
INFO  - WebXmlFile - web.xml: url mapping found for filter with 
name wicket.NestedModals: [/*]
INFO  - Application- [wicket.NestedModals] init: Wicket core 
library initializer
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=IBehaviorListener, method=public abstract void 
org.apache.wicket.behavior.IBehaviorListener.onRequest()]
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=IFormSubmitListener, method=public abstract void 
org.apache.wicket.markup.html.form.IFormSubmitListener.onFormSubmitted()]
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=ILinkListener, method=public abstract void 
org.apache.wicket.markup.html.link.ILinkListener.onLinkClicked()]
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=IOnChangeListener, method=public abstract void 
org.apache.wicket.markup.html.form.IOnChangeListener.onSelectionChanged()]
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=IRedirectListener, method=public abstract void 
org.apache.wicket.IRedirectListener.onRedirect()]
INFO  - RequestListenerInterface   - registered listener interface 
[RequestListenerInterface name=IResourceListener, method=public abstract void 
org.apache.wicket.IResourceListener.onResourceRequested()]
INFO  - Application- [wicket.NestedModals] init: Wicket 
extensions initializer
INFO  - WebApplication - [wicket.NestedModals] Started Wicket 
version 6.9.0-SNAPSHOT in DEVELOPMENT mode

*** WARNING: Wicket is running in DEVELOPMENT mode.  ***
***   ^^^***
*** Do NOT deploy to your live server(s) without changing this.  ***
*** See Application#getConfigurationType() for more information. ***

INFO  - AbstractConnector  - Started SocketConnector@0.0.0.0:8080
INFO  - SslContextFactory  - Enabled Protocols [SSLv2Hello, SSLv3, 
TLSv1, TLSv1.1, TLSv1.2] of [SSLv2Hello, SSLv3, TLSv1, TLSv1.1, TLSv1.2]
INFO  - AbstractConnector  - Started SslSocketConnector@0.0.0.0:8443
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - CompoundRequestMapper  - No compatible mapper found for URL ''
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - ServletWebRequest  - Calculating context relative path from: 
context path '', filterPrefix '', uri '/'
DEBUG - DefaultPageFactory - Found constructor for Page of type 'class 
com.qs.NestedModals.HomePage' and argument of type 'class 
org.apache.wicket.request.mapper.parameter.PageParameters'.
DEBUG - PageAccessSynchronizer - 'qtp2128350680-16' attempting to acquire 
lock to page with id '0'
DEBUG - PageAccessSynchronizer - qtp2128350680-16 acquired lock to page 0
DEBUG - MarkupContainer- Add content to [ModalWindow [Component id 
= outerModalWindow]]
DEBUG - MarkupContainer- Replacing content in [ModalWindow 
[Component id = outerModalWindow]]
DEBUG - MarkupContainer- Add outerModalWindow to