[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485589#comment-17485589
]
ASF GitHub Bot commented on WICKET-6952:
martin-g commented on a change in pull request #497:
martin-g commented on a change in pull request #497:
URL: https://github.com/apache/wicket/pull/497#discussion_r797322895
##
File path: wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
##
@@ -66,6 +66,26 @@
return argument;
}
+
[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485489#comment-17485489
]
ASF GitHub Bot commented on WICKET-6952:
theigl commented on pull request #497:
URL:
theigl commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027300865
```
BenchmarkMode Cnt Score Error
Units
StringsBenchmark.bufferFastIsEmpty thrpt 15 1918461027.579 ± 4949234.208
ops/s
[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485488#comment-17485488
]
ASF GitHub Bot commented on WICKET-6952:
theigl removed a comment on pull request #497:
URL:
theigl removed a comment on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027288730
OK my previous benchmark was flawed because I created a new buffer for every
run. The new `isEmpty` method for `AppendingStringBuffer` is actually 40-50x
faster for
[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485487#comment-17485487
]
ASF GitHub Bot commented on WICKET-6952:
theigl edited a comment on pull request #497:
URL:
theigl edited a comment on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027288730
OK my previous benchmark was flawed because I created a new buffer for every
run. The new `isEmpty` method for `AppendingStringBuffer` is actually 40-50x
faster for
[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485486#comment-17485486
]
ASF GitHub Bot commented on WICKET-6952:
theigl commented on pull request #497:
URL:
Thomas Heigl created WICKET-6952:
Summary: Performance improvements for Strings.isEmpty
Key: WICKET-6952
URL: https://issues.apache.org/jira/browse/WICKET-6952
Project: Wicket
Issue Type:
theigl commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027297383
https://issues.apache.org/jira/browse/WICKET-6952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
theigl commented on a change in pull request #497:
URL: https://github.com/apache/wicket/pull/497#discussion_r797023488
##
File path: wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
##
@@ -66,6 +66,26 @@
return argument;
}
+ /**
theigl commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027288730
OK my previous benchmark was flawed because I created a new buffer for every
run. The new `isEmpty` method for `AppendingStringBuffer´ is actually 40-50x
faster for medium-sized
theigl commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027257846
Right, I'll add the JavaDoc and the ticket tomorrow!
> It would be good to have the benchmark code for future reference - either
here as a comment or somewhere in the source
martin-g commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027215114
And please create a JIRA issue - for the changelog
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
martin-g commented on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027214721
It would be good to have the benchmark code for future reference - either
here as a comment or somewhere in the source tree
--
This is an automated message from the Apache Git
martin-g commented on a change in pull request #497:
URL: https://github.com/apache/wicket/pull/497#discussion_r796930980
##
File path: wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
##
@@ -531,8 +531,24 @@ else if (aChar == 'f')
*/
theigl opened a new pull request #497:
URL: https://github.com/apache/wicket/pull/497
This PR adds some micro-improvements for `Strings.isEmpty`.
`String.trim` is one of the hottest methods in my application. Most calls
come from `Strings.isEmpty`, either called directly or via
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new 233b65a Update japicmp-maven-plugin to
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch wicket-9.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/wicket-9.x by this push:
new 46eabaa Update japicmp-maven-plugin
Thorsten Wendelmuth created WICKET-6951:
---
Summary: WicketTester loses formInput of sibiling-forms if nested
form is submitted
Key: WICKET-6951
URL: https://issues.apache.org/jira/browse/WICKET-6951
21 matches
Mail list logo
