[activemq-artemis] branch master updated: ARTEMIS-2288 add remote IP to handshake timeout error

[clebertsuconic]

This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/master by this push:
     new d2dc04c  ARTEMIS-2288 add remote IP to handshake timeout error
     new 54cfeed  This closes #2595
d2dc04c is described below

commit d2dc04c712716142de8c27c7b879e22ae257186a
Author: Justin Bertram <jbert...@apache.org>
AuthorDate: Wed Mar 27 12:00:04 2019 -0500

    ARTEMIS-2288 add remote IP to handshake timeout error
---
 .../org/apache/activemq/artemis/core/protocol/ProtocolHandler.java    | 2 +-
 .../org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
index e68e814..387e9e6 100644
--- 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
+++ 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
@@ -116,7 +116,7 @@ public class ProtocolHandler {
       public void channelActive(ChannelHandlerContext ctx) throws Exception {
          if (handshakeTimeout > 0) {
             timeoutFuture = scheduledThreadPool.schedule( () -> {
-               ActiveMQServerLogger.LOGGER.handshakeTimeout(handshakeTimeout);
+               ActiveMQServerLogger.LOGGER.handshakeTimeout(handshakeTimeout, 
ctx.channel().remoteAddress().toString());
                ctx.channel().close();
             }, handshakeTimeout, TimeUnit.SECONDS);
          }
diff --git 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
index 9ed1419..a8e9e3d 100644
--- 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
+++ 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
@@ -1960,8 +1960,8 @@ public interface ActiveMQServerLogger extends BasicLogger 
{
    void errorAnnouncingBackup(String backupManager);
 
    @LogMessage(level = Logger.Level.ERROR)
-   @Message(id = 224088, value = "Timeout ({0} seconds) while handshaking has 
occurred.", format = Message.Format.MESSAGE_FORMAT)
-   void handshakeTimeout(int timeout);
+   @Message(id = 224088, value = "Timeout ({0} seconds) while handshaking with 
{1} has occurred.", format = Message.Format.MESSAGE_FORMAT)
+   void handshakeTimeout(int timeout, String remoteAddress);
 
    @LogMessage(level = Logger.Level.WARN)
    @Message(id = 224089, value = "Failed to calculate persistent size", format 
= Message.Format.MESSAGE_FORMAT)